From dev-return-21466-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Tue Jan 22 20:46:13 2013 Return-Path: X-Original-To: apmail-openjpa-dev-archive@www.apache.org Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF7CAE13C for ; Tue, 22 Jan 2013 20:46:13 +0000 (UTC) Received: (qmail 69351 invoked by uid 500); 22 Jan 2013 20:46:13 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 69305 invoked by uid 500); 22 Jan 2013 20:46:13 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 69132 invoked by uid 99); 22 Jan 2013 20:46:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jan 2013 20:46:13 +0000 Date: Tue, 22 Jan 2013 20:46:13 +0000 (UTC) From: "Helen Xu (JIRA)" To: dev@openjpa.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (OPENJPA-2295) speed up query metadata lookup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OPENJPA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Helen Xu updated OPENJPA-2295: ------------------------------ Attachment: OPENJPA-2295a.patch > speed up query metadata lookup > ------------------------------ > > Key: OPENJPA-2295 > URL: https://issues.apache.org/jira/browse/OPENJPA-2295 > Project: OpenJPA > Issue Type: New Feature > Components: performance, query > Affects Versions: 2.2.0, 2.3.0 > Reporter: Helen Xu > Assignee: Helen Xu > Priority: Minor > Fix For: 2.3.0, 2.2.2 > > Attachments: OPENJPA-2295a.patch, OPENJPA-2295.patch > > > I noticed right now the queryKey is used as the map key for metadataRepository._queries, but when it goes to look up, it always uses query name. The query metadata lookup would be faster if we switch to query name as the key. > I double checked the JPA Spec and OPENJPA menu, it seems only support the named query creation using query name, which means the query name should be unique in one EntityManager. It doesn't matter in which entity the query is defined. So using name as the map look up key should be good enough. > when there are two queries with the same name defined in the different entities, it will only keep the query metadata for the first loaded named query and ignore the rest plus log a warning message like this: > WARN [main] openjpa.MetaData - Ignoring duplicate query "X" in "class org.apache.openjpa.A". A query with the same name been already declared in "class org.apache.openjpa.B". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira