From dev-return-19861-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Thu Jan 5 14:36:04 2012 Return-Path: X-Original-To: apmail-openjpa-dev-archive@www.apache.org Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D050491E9 for ; Thu, 5 Jan 2012 14:36:04 +0000 (UTC) Received: (qmail 75085 invoked by uid 500); 5 Jan 2012 14:36:04 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 74493 invoked by uid 500); 5 Jan 2012 14:36:03 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 74469 invoked by uid 99); 5 Jan 2012 14:36:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2012 14:36:02 +0000 X-ASF-Spam-Status: No, hits=-2001.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2012 14:36:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B5B6A13A380 for ; Thu, 5 Jan 2012 14:35:39 +0000 (UTC) Date: Thu, 5 Jan 2012 14:35:39 +0000 (UTC) From: "Rick Curtis (Resolved) (JIRA)" To: dev@openjpa.apache.org Message-ID: <1414288479.9339.1325774139746.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <649146250.46476.1324998390620.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (OPENJPA-2101) PersistenceProductDerivation overwrites the RemoteCommitProvider configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-2101?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick Curtis resolved OPENJPA-2101. ---------------------------------- Resolution: Fixed Pinaki committed revision 1224948 to trunk to resolve this issue. =20 > PersistenceProductDerivation overwrites the RemoteCommitProvider configur= ation > -------------------------------------------------------------------------= ----- > > Key: OPENJPA-2101 > URL: https://issues.apache.org/jira/browse/OPENJPA-2101 > Project: OpenJPA > Issue Type: Bug > Components: kernel > Affects Versions: 2.1.1, 2.2.0 > Reporter: Pedro Aquilino S=C3=A1nchez > Fix For: 2.2.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > If you set the property openjpa.RemoteCommitProvider to a value distinct = from the default (for example "tcp" or "jms"), this value is overwritted wi= th the default "sjvm". > PersistenceProductDerivation uses a incorrect conditional to check if the= value is empty. In this code: > // If the datacache is enabled, make sure we have a Remote= CommitProvider > String dc =3D oconf.getDataCache(); > String rcp =3D oconf.getRemoteCommitProvider(); > // If the datacache is set and is something other than fal= se > if (dc !=3D null && dc.equals("false") =3D=3D false) { > // If RCP is null or empty, set it to sjvm. > if (rcp =3D=3D null || (rcp !=3D null && rcp.equals(""= ) =3D=3D false)) { > oconf.setRemoteCommitProvider("sjvm"); > } > } > The last conditional must be > if (rcp =3D=3D null || (rcp !=3D null && rcp.equals(""))) { -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira