Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: domain of michael.d.dick@gmail.com
 designates 209.85.213.46 as permitted sender)
MIME-Version: 1.0
From: Michael Dick <michael.d.dick@gmail.com>
Date: Wed, 29 Jun 2011 08:55:37 -0500
Message-ID: <BANLkTinuYa5xyaKM_du-jycHpLkyjKRzpg@mail.gmail.com>
Subject: Metamodel generates ListAttribute for arrays instead of
 SingularAttribute
To: dev@openjpa.apache.org
Content-Type: multipart/alternative; boundary=001485f5470ac9ea9804a6da2446

--001485f5470ac9ea9804a6da2446
Content-Type: text/plain; charset=ISO-8859-1

Does anyone remember why we generate a ListAttribute for arrays instead of a
SingularAttribute?

In section 6.2.1.1. the JPA spec indicates that we should generate a
SingularAttribute for every non-collection-valued field, and a
Collection|Set|List Attribute for their respective types.

Generating a ListAttribute for a @PersistentCollection makes sense, but
generating it for all arrays, doesn't look quite right. AFAICT this code was
added under OPENJPA-1013, but that was a general development task. There
weren't any clues to the motivation for this part of the change, except that
one of the testcases does use a @PersistentCollection.

At any rate, this seems wrong to me, but before I start modifying code I
wanted to make sure I'm not missing something.

Thanks,
-mike

--001485f5470ac9ea9804a6da2446--