Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Date: Fri, 11 Feb 2011 22:30:57 +0000 (UTC)
From: "Michael Dick (JIRA)" <jira@apache.org>
To: dev@openjpa.apache.org
Message-ID: 
 <791195620.11766.1297463457566.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <7792970.116011294084185776.JavaMail.jira@thor>
Subject: [jira] Commented: (OPENJPA-1912) enhancer generates invalid code if
 fetch-groups is activated
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OPENJPA-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993736#comment-12993736 ] 

Michael Dick commented on OPENJPA-1912:
---------------------------------------

You're right. I thought it only checked when the PCEnhancer was executed, but after looking at the code it's the MetaDataRepository that triggers the check. 

> enhancer generates invalid code if fetch-groups is activated
> ------------------------------------------------------------
>
>                 Key: OPENJPA-1912
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1912
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: Enhance
>    Affects Versions: 2.0.0, 2.0.1, 2.1.0
>            Reporter: Mark Struberg
>            Priority: Critical
>         Attachments: OPENJPA-1912-enhancer.patch, OPENJPA-1912-fix-wo_cleanup-2.patch, OPENJPA-1912-fix-wo_cleanup.patch, OPENJPA-1912-mdd.diff.txt, OPENJPA-1912-test.patch
>
>
> If openjpa.DetachState =fetch-groups is used, the enhancer will add a 'implements Externalizable' + writeExternal + readExternal.
> The problem is, that writeExternal and readExternal will also try to externalize the private members of any given superclass. Thus we get a runtime Exception that we are not allowed to access those fields.
> Example:
> @Entity
> public abstract class AbstractGroup {
>    ...
>     @Temporal(TemporalType.TIMESTAMP)
>     @TrackChanges
>     private Date applicationBegin;
>  ...
> }
> and 
> @Entity
> public class Group extends AbstractGroup {
> ...
> }
> will result in the following code (decompiled with jad):
>     public void writeExternal(ObjectOutput objectoutput)
>         throws IOException
>     {
>         pcWriteUnmanaged(objectoutput);
>         if(pcStateManager != null)
>         {
>             if(pcStateManager.writeDetached(objectoutput))
>                 return;
>         } else
>         {
>             objectoutput.writeObject(pcGetDetachedState());
>             objectoutput.writeObject(null);
>         }
>         objectoutput.writeObject(applicationBegin);
>         objectoutput.writeObject(applicationEnd);
>         objectoutput.writeObject(applicationLocked);
>         objectoutput.writeObject(approvalRequired);
>  ...

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira