openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Curtis (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (OPENJPA-1886) Query trace may contain sensitive information and should not be logged by default.
Date Tue, 16 Nov 2010 22:21:13 GMT

     [ https://issues.apache.org/jira/browse/OPENJPA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Curtis resolved OPENJPA-1886.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0

Commited the bug fix and a few new test cases.

I'm not real excited about how I had to fix this problem though... Currently we turn this
behavior off/on by setting openjpa.ConnectionFactoryProperties=PrintParameters=true but ideally
this would be configured via openjpa.Log=PrintParameters=true... but as I know Mike found
out when trying to fix OPENJPA-1678, that isn't a trivial task.  If I understand the code
correctly, to support PrintParameters on openjpa.Log we would need to modify the LogFactory
interface, and potentially break any and all external implementers of that interface.

This isn't an ideal fix, but it does fix the reported problem.

> Query trace may contain sensitive information and should not be logged by default.
> ----------------------------------------------------------------------------------
>
>                 Key: OPENJPA-1886
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1886
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 2.0.2, 2.1.0
>            Reporter: Rick Curtis
>            Assignee: Rick Curtis
>             Fix For: 2.1.0
>
>
> This is the same problem as reported by OPENJPA-1678 except it is coming from openjpa.Query.
> To recreate this problem, run org.apache.openjpa.persistence.querycache.TestQueryCache
and enable "openjpa.Log","Query=trace". 
> 375  test  TRACE  [main] openjpa.Query - Executing query: [SELECT o FROM Entity1 o WHERE
o.pk = :pk] with parameters: {pk=2}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message