From dev-return-17522-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Tue Oct 05 13:47:02 2010 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 57535 invoked from network); 5 Oct 2010 13:47:02 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 Oct 2010 13:47:02 -0000 Received: (qmail 57818 invoked by uid 500); 5 Oct 2010 13:47:01 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 57650 invoked by uid 500); 5 Oct 2010 13:46:58 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 57636 invoked by uid 99); 5 Oct 2010 13:46:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Oct 2010 13:46:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Oct 2010 13:46:54 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o95DkWFB016926 for ; Tue, 5 Oct 2010 13:46:33 GMT Message-ID: <32138370.546831286286392651.JavaMail.jira@thor> Date: Tue, 5 Oct 2010 09:46:32 -0400 (EDT) From: "Michael Dick (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-1823) Is merge() seriously broken? In-Reply-To: <28282483.540101286235941775.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917978#action_12917978 ] Michael Dick commented on OPENJPA-1823: --------------------------------------- The snippets you provided don't seem broken. Is there an else block that you're concerned about? > Is merge() seriously broken? > ---------------------------- > > Key: OPENJPA-1823 > URL: https://issues.apache.org/jira/browse/OPENJPA-1823 > Project: OpenJPA > Issue Type: Bug > Components: Enhance, kernel > Reporter: Pinaki Poddar > > Does someone recently rewrite the critical method pcIsDetached() in PCEnhancer and broke it? > This is a piece of code in isDetached(Object obj) method of BrokerImpl > PersistenceCapable pc = ...; > Boolean detached = pc.pcIsDetached(); > if (detached != null) > return detached.booleanValue(); > A enhanced PersistenceCapable has the following in its pcIsDetached() > public Boolean pcIsDetached() > { > if(pcStateManager != null) > if(pcStateManager.isDetached()) > return Boolean.TRUE; > else > return Boolean.FALSE; > if(pcGetDetachedState() != null && pcGetDetachedState() != PersistenceCapable.DESERIALIZED) > return Boolean.TRUE; > if(version != 0) > return Boolean.TRUE; > if(pcVersionInit) > { > return Boolean.TRUE; > } else > { > return Boolean.FALSE; > } > } > The method never returns null. But that is what BrokerImpl checks for. > Does someone recently rewrite this critical method in PCEnhancer and broke it? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.