From dev-return-17534-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Thu Oct 07 11:32:56 2010
Return-Path: <dev-return-17534-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org>
Delivered-To: apmail-openjpa-dev-archive@www.apache.org
Received: (qmail 54832 invoked from network); 7 Oct 2010 11:32:56 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 7 Oct 2010 11:32:56 -0000
Received: (qmail 49319 invoked by uid 500); 7 Oct 2010 11:32:56 -0000
Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org
Received: (qmail 49157 invoked by uid 500); 7 Oct 2010 11:32:53 -0000
Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@openjpa.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@openjpa.apache.org>
List-Post: <mailto:dev@openjpa.apache.org>
List-Id: <dev.openjpa.apache.org>
Reply-To: dev@openjpa.apache.org
Delivered-To: mailing list dev@openjpa.apache.org
Received: (qmail 49137 invoked by uid 99); 7 Oct 2010 11:32:51 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Oct 2010 11:32:51 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Oct 2010 11:32:51 +0000
Received: from thor (localhost [127.0.0.1])
	by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o97BWUT6027120
	for <dev@openjpa.apache.org>; Thu, 7 Oct 2010 11:32:30 GMT
Message-ID: <30824152.24271286451150598.JavaMail.jira@thor>
Date: Thu, 7 Oct 2010 07:32:30 -0400 (EDT)
From: "Lucas Partridge (JIRA)" <jira@apache.org>
To: dev@openjpa.apache.org
Subject: [jira] Created: (OPENJPA-1825) Replace non-null with nullable
 instead of optional
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Replace non-null with nullable instead of optional
--------------------------------------------------

                 Key: OPENJPA-1825
                 URL: https://issues.apache.org/jira/browse/OPENJPA-1825
             Project: OpenJPA
          Issue Type: Sub-task
          Components: tooling
    Affects Versions: 2.0.0
         Environment: WinXP
            Reporter: Lucas Partridge


Currently the migration tool (which is very useful!) replaces the 'not-null' attribute of Hibernate's 'property' with the 'optional' attribute for OpenJPA.  However, when using runtime forward mapping with the resulting orm file the generated DDL doesn't recognise the value of the optional attribute.  The database column has IS_NULL = YES.

So the first thing is, can we please replace this section in migration-actions.xml for the 'property' action:

	<rename-attr from="not-null" to="optional">
		<map-value from="true"  to="false"/>
		<map-value from="false" to="true"/>
	</rename-attr>
with:
    <promote-attr from="column" to="column" as="name">
 ....
      <consume-attr from="not-null" to="nullable">
        <map-value from="true"  to="false"/>
        <map-value from="false" to="true"/>
      </consume-attr>
    </promote-attr>

...because the nullable attribute is honoured by the DDL as required (e.g., nullable="false" becomes IS_NULL=NO in the db).

The second thing is that when I do this the values don't get reveresed as expected.  For example, the following Hibernate line:

<property name="value" column="VALUE" type="text" length="10000000" not-null="true"/>

becomes:

      <basic name="value">
        <column length="10000000" name="VALUE" nullable="true"/>
      </basic>

...instead of the expected nullable="false".  Have you tested map-value elements when they're embedded inside consume-attr elements?  It looks like it's not working there.  They do appear to work however when inside rename-attr elements.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.