From dev-return-17531-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Wed Oct 06 13:24:57 2010 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 43418 invoked from network); 6 Oct 2010 13:24:57 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 6 Oct 2010 13:24:57 -0000 Received: (qmail 51605 invoked by uid 500); 6 Oct 2010 13:24:57 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 51526 invoked by uid 500); 6 Oct 2010 13:24:55 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 51518 invoked by uid 99); 6 Oct 2010 13:24:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Oct 2010 13:24:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Oct 2010 13:24:52 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o96DOUKU006003 for ; Wed, 6 Oct 2010 13:24:30 GMT Message-ID: <17916787.6311286371470652.JavaMail.jira@thor> Date: Wed, 6 Oct 2010 09:24:30 -0400 (EDT) From: "Rick Curtis (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-1801) CacheStatistics misses are improperly calculated. In-Reply-To: <5542236.237611284671672369.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918510#action_12918510 ] Rick Curtis commented on OPENJPA-1801: -------------------------------------- @Pinaki - I came across that javadoc after I opened this JIRA, but I think in the code that I replaced we could have determined done a better job at determining the runtime type that was being cached. Either way I think we're in a better place than what we were. I'm not sure if you looked at the changes I made, but from a high level I moved statistics calculation from the DataCache level up to the (DataCache)StoreManager level. I did this because only the StoreManager knows when a hit is really a hit. > CacheStatistics misses are improperly calculated. > ------------------------------------------------- > > Key: OPENJPA-1801 > URL: https://issues.apache.org/jira/browse/OPENJPA-1801 > Project: OpenJPA > Issue Type: Bug > Components: datacache > Affects Versions: 2.0.1, 2.1.0 > Reporter: Rick Curtis > Assignee: Rick Curtis > Fix For: 2.1.0 > > > In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.