[ https://issues.apache.org/jira/browse/OPENJPA-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922553#action_12922553 ] 

Rick Curtis commented on OPENJPA-1842:
--------------------------------------

I thought about this some more last night and we're not fixing the right problem here. I think the problem is that we don't have a good way to create these special Oracle triggers in our unit test bucket.? Going the route of making sure that all of our unit tests don't use GenerationType.IDENTITY is going to be error prone, and we'll be continually chasing this problem. How feasible is it to add support for GenerationType.IDENTITY?

FYI -- As of this morning I found 20 instances of "@GeneratedValue(strategy = GenerationType.IDENTITY) " in our test bucket, but I'm not sure how many of those are actually used.



> CachedEntityStatistics depends on @GeneratedValue which is not supported in Oracle by default
> ---------------------------------------------------------------------------------------------
>
>                 Key: OPENJPA-1842
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1842
>             Project: OpenJPA
>          Issue Type: Test
>    Affects Versions: 2.0.0, 2.0.1
>            Reporter: Albert Lee
>            Assignee: Albert Lee
>            Priority: Minor
>             Fix For: 2.0.2, 2.1.0
>
>
> CachedEntityStatistics depends on @GeneratedValue which is not supported in Oracle by default unless special trigger and OracleDictionary setting is implemented.
> Otherwise, the following similar exception will be observed.
> Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: ORA-01400: cannot insert NULL into ("JPAUSER"."CACHEDENTITYSTATISTICS"."ID")
>  {prepstmnt 406657085 INSERT INTO CachedEntityStatistics (firstName, lastName, version) VALUES (?, ?, ?) [params=?, ?, ?]} [code=1400, state=23000]
> SInce TestStatistics, the test case uses CachedEntityStatistics, is not testing GeneratedValue per se, will remove the annotation and implement a simple id assignment in CachedEntityStatistics  class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.