openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harald Wellmann (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (OPENJPA-1784) Map value updates not flushed
Date Wed, 08 Sep 2010 13:37:37 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907210#action_12907210
] 

Harald Wellmann edited comment on OPENJPA-1784 at 9/8/10 9:37 AM:
------------------------------------------------------------------

The attachment MapUpdate.patch contains a unit test exhibiting the problem. A test which updates
a map key passes. Another test which only update the map value fails.

      was (Author: hwellmann):
    Unit test exhibiting the problem. A test which updates a map key passes. Another test
which only update the map value fails.
  
> Map value updates not flushed
> -----------------------------
>
>                 Key: OPENJPA-1784
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1784
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.0.1
>            Reporter: Harald Wellmann
>         Attachments: MapUpdate.patch
>
>
> I have an entity with a map element collection where the map value is an Embeddable.
> @Embeddable
> public class LocalizedString {
>     private String language;
>     private String string;
>     // getters and setters omitted
> }
>  
> @Entity
> public class MultilingualString {
>     @Id
>     private long id;
>     @ElementCollection(fetch=FetchType.EAGER)
>     private Map<String, LocalizedString> map = new HashMap<String, LocalizedString>();
> }
> Given a persistent instance m of my entity, I update a member of a given map value and
then merge the modified entity:
>     EntityManager em = ...;
>     em.getTransaction().begin();
>     m.getMap().get("en").setString("foo");
>     em.merge(m)
>     em.getTransaction().commit();
>    
> The problem is, the state change of the map does not get saved to the database. With
DEBUG logging on, I can see that the flush on commit does not trigger any SQL UPDATE.
> To force the update, I have to put a new value into the map instead of just changing
the existing one.
>     EntityManager em = ...;
>     em.getTransaction().begin();
>     m.getMap().put("en"), new LocalizedString("en", "foo"));
>     em.merge(m)
>     em.getTransaction().commit();
> After this change, I do see the expected UPDATE.
> My Embeddable does have hashCode() and equals() implemented such that the changed map
is not equal() to the former version in either case.
> This looks like a bug in the dirty-checking logic in OpenJPA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message