Return-Path: 
 <dev-return-17206-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org>
Delivered-To: apmail-openjpa-dev-archive@www.apache.org
Received: (qmail 85177 invoked from network); 23 Aug 2010 15:38:10 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 23 Aug 2010 15:38:10 -0000
Received: (qmail 39400 invoked by uid 500); 23 Aug 2010 15:38:09 -0000
Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org
Received: (qmail 39306 invoked by uid 500); 23 Aug 2010 15:38:09 -0000
Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@openjpa.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@openjpa.apache.org>
List-Post: <mailto:dev@openjpa.apache.org>
List-Id: <dev.openjpa.apache.org>
Reply-To: dev@openjpa.apache.org
Delivered-To: mailing list dev@openjpa.apache.org
Received: (qmail 39298 invoked by uid 99); 23 Aug 2010 15:38:08 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Aug 2010 15:38:08 +0000
X-ASF-Spam-Status: No, hits=0.7 required=10.0
	tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL,UNPARSEABLE_RELAY
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [76.13.13.41] (HELO smtp102.prem.mail.ac4.yahoo.com)
 (76.13.13.41)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 23 Aug 2010 15:38:02 +0000
Received: (qmail 86441 invoked from network); 23 Aug 2010 15:37:41 -0000
Received: from drwoods.local (dwoods@174.99.58.61 with plain)
        by smtp102.prem.mail.ac4.yahoo.com with SMTP;
 23 Aug 2010 08:37:41 -0700 PDT
X-Yahoo-SMTP: sCI.ryiswBB7FW.DxjU523c87MI-
X-YMail-OSG: MzLPBAQVM1kJitFAcSPtQ951JpgHzJwjSe.yZyuPqMz.eoo
 5vUlUKFDRe4Kt43DbG_FJDgcgYUoHU4eIP7nI_1USD0ece0lwVNUQPef9ofr
 75M6DHAxfMRdXKR4XCMFhGLv_OCuE2X73Onpfcc5g0TQz8.EHV15G7IZ.7YE
 vbkttbZsLqoxPWCAzIEHa.7Rf1oNrNMKxjxhLnA_083U8LZdralv4GIXQN6u
 3xB_0rIolwLeasg.AiPDD6nfUhRQiXDNNjTD.F9OLyIoPiFpf5n3GhO8K9t_
 h0MeTnWf4SVXfzjcOnHplGGZVsb5CfOfmi4QI_Oyw847ogbgdglvGCO8c
X-Yahoo-Newman-Property: ymail-3
Message-ID: <4C7295C4.2050308@apache.org>
Date: Mon, 23 Aug 2010 11:37:40 -0400
From: Donald Woods <dwoods@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.8) Gecko/20100802 Lightning/1.0b2 Thunderbird/3.1.2
MIME-Version: 1.0
To: dev@openjpa.apache.org
Subject: Re: Rat plugin
References: <AANLkTimBOFVwMJ9HjXBcoCgg4rCnGm0Pc6dgSkRvDrIx@mail.gmail.com>
 <4C0FABBE.6060100@apache.org> <4C0FB190.9070804@apache.org>
 <AANLkTimAMIw9gg2_V5-EXr53kOEvMXxFQTl7zEyvhvhU@mail.gmail.com>
 <1e51b424.12e935d7.4c6fe774.c02da@o2.pl>
In-Reply-To: <1e51b424.12e935d7.4c6fe774.c02da@o2.pl>
X-Enigmail-Version: 1.1.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Yes, temporary change until I get the new release profiles working with
the Apache Nexus repository....


-Donald


On 8/21/10 10:49 AM, Miłosz Tylenda wrote:
> Hi All!
> 
> Since revision 987238 the excludes list came back and the includes list vanished. Is it intentional?
> 
> Cheers,
> Milosz
> 
>> Thanks Donald!
>>
>> On Wed, Jun 9, 2010 at 10:21 AM, Donald Woods <dwoods@apache.org> wrote:
>>
>>> OK, updated builds in r953040 to only run apache-rat against certain
>>> source files under the /src/ dirs during the normal builds and only runs
>>> the more detailed checks during release builds -
>>>
>>> +                    <includes>
>>> +                        <!-- only check common source files -->
>>> +                        <include>**/src/**/*.bat</include>
>>> +                        <include>**/src/**/*.css</include>
>>> +                        <include>**/src/**/*.html</include>
>>> +                        <include>**/src/**/*.java</include>
>>> +                        <include>**/src/**/*.js</include>
>>> +                        <include>**/src/**/*.jsp</include>
>>> +                        <include>**/src/**/*.properties</include>
>>> +                        <include>**/src/**/*.sh</include>
>>> +                        <include>**/src/**/*.txt</include>
>>> +                        <include>**/src/**/*.vm</include>
>>> +                        <include>**/src/**/*.xml</include>
>>> +                    </includes>
>>>
>>>
>>> On 6/9/10 10:57 AM, Donald Woods wrote:
>>>> I'll look at changing the RAT usage in normal builds to use an
>>>> <includes> list, to only include "source" type files and leave the
>>>> normal exhaustive check using <excludes> to the release profile....
>>>>
>>>>
>>>> -Donald
>>>>
>>>>
>>>> On 6/9/10 10:07 AM, Michael Dick wrote:
>>>>> I'm in the same boat. I tend to save the output of svn diff to the
>>>>> development root directory when I'm switching to a different issue /
>>> task.
>>>>>
>>>>> It's certainly possible to selectively skip the rat check - if we make
>>> some
>>>>> changes to pom.xml. It's just going to defer the build problem until
>>> someone
>>>>> else does a build.
>>>>>
>>>>> A better fix would be to request an update to RAT such that it only
>>> checks
>>>>> files which are in version control - or optionally accepts an exclude
>>> list
>>>>> from a file ( we could then populate the file with output from svn
>>> stat).
>>>>>
>>>>> There may be other options too, but I'd try the RAT route first -
>>> especially
>>>>> if more people are affected by this change.
>>>>>
>>>>> -mike
>>>>>
>>>>> On Wed, Jun 9, 2010 at 8:36 AM, Rick Curtis <curtisr7@gmail.com> wrote:
>>>>>
>>>>>> Now that rat runs as part of my local builds, is there some way that I
>>> can
>>>>>> disable it via a system property? I have numerous files in my dev
>>>>>> environment that doesn't have an ASF license header and I have no
>>>>>> intentions
>>>>>> on ever checking this stuff in.
>>>>>>
>>>>>> Thanks,
>>>>>> Rick
>>>>>>
>>>>>
>>>>
>>>
>>
>