openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: Rat plugin
Date Mon, 23 Aug 2010 15:37:40 GMT
Yes, temporary change until I get the new release profiles working with
the Apache Nexus repository....


-Donald


On 8/21/10 10:49 AM, MiƂosz Tylenda wrote:
> Hi All!
> 
> Since revision 987238 the excludes list came back and the includes list vanished. Is
it intentional?
> 
> Cheers,
> Milosz
> 
>> Thanks Donald!
>>
>> On Wed, Jun 9, 2010 at 10:21 AM, Donald Woods <dwoods@apache.org> wrote:
>>
>>> OK, updated builds in r953040 to only run apache-rat against certain
>>> source files under the /src/ dirs during the normal builds and only runs
>>> the more detailed checks during release builds -
>>>
>>> +                    <includes>
>>> +                        <!-- only check common source files -->
>>> +                        <include>**/src/**/*.bat</include>
>>> +                        <include>**/src/**/*.css</include>
>>> +                        <include>**/src/**/*.html</include>
>>> +                        <include>**/src/**/*.java</include>
>>> +                        <include>**/src/**/*.js</include>
>>> +                        <include>**/src/**/*.jsp</include>
>>> +                        <include>**/src/**/*.properties</include>
>>> +                        <include>**/src/**/*.sh</include>
>>> +                        <include>**/src/**/*.txt</include>
>>> +                        <include>**/src/**/*.vm</include>
>>> +                        <include>**/src/**/*.xml</include>
>>> +                    </includes>
>>>
>>>
>>> On 6/9/10 10:57 AM, Donald Woods wrote:
>>>> I'll look at changing the RAT usage in normal builds to use an
>>>> <includes> list, to only include "source" type files and leave the
>>>> normal exhaustive check using <excludes> to the release profile....
>>>>
>>>>
>>>> -Donald
>>>>
>>>>
>>>> On 6/9/10 10:07 AM, Michael Dick wrote:
>>>>> I'm in the same boat. I tend to save the output of svn diff to the
>>>>> development root directory when I'm switching to a different issue /
>>> task.
>>>>>
>>>>> It's certainly possible to selectively skip the rat check - if we make
>>> some
>>>>> changes to pom.xml. It's just going to defer the build problem until
>>> someone
>>>>> else does a build.
>>>>>
>>>>> A better fix would be to request an update to RAT such that it only
>>> checks
>>>>> files which are in version control - or optionally accepts an exclude
>>> list
>>>>> from a file ( we could then populate the file with output from svn
>>> stat).
>>>>>
>>>>> There may be other options too, but I'd try the RAT route first -
>>> especially
>>>>> if more people are affected by this change.
>>>>>
>>>>> -mike
>>>>>
>>>>> On Wed, Jun 9, 2010 at 8:36 AM, Rick Curtis <curtisr7@gmail.com>
wrote:
>>>>>
>>>>>> Now that rat runs as part of my local builds, is there some way that
I
>>> can
>>>>>> disable it via a system property? I have numerous files in my dev
>>>>>> environment that doesn't have an ASF license header and I have no
>>>>>> intentions
>>>>>> on ever checking this stuff in.
>>>>>>
>>>>>> Thanks,
>>>>>> Rick
>>>>>>
>>>>>
>>>>
>>>
>>
> 

Mime
View raw message