openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Curtis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1706) In JDBCStoreManager . connect method, should check if connection is closed
Date Tue, 20 Jul 2010 16:11:49 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890290#action_12890290
] 

Rick Curtis commented on OPENJPA-1706:
--------------------------------------

@David -- So once you fixed the Spring managed tran problem this code change wasn't necessary?

> In JDBCStoreManager . connect method, should check if connection is closed
> --------------------------------------------------------------------------
>
>                 Key: OPENJPA-1706
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1706
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 1.2.2, 2.0.0
>         Environment: We were using 1.2.2, but I see the same problem code in trunk.
>            Reporter: David Wolverton
>            Assignee: Rick Curtis
>            Priority: Minor
>         Attachments: OPENJPA-1706.patch
>
>
> The code currently reads:
> // connect if the connection is currently null, or if
> // the connection has been closed out from under us
> if (_conn == null)
>     _conn = connectInternal();
> The comment indicates that it should check for null or closed, but the code only checks
for closed. Our application got to the state where connection was actually closed but not
null. We patched this with the following code to make it work:
> if (_conn == null || _conn.isClosed())
>     _conn = connectInternal();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message