openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: svn commit: r956705 - /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
Date Tue, 22 Jun 2010 17:29:42 GMT
OK, rolled back change in r956959.  Thanks for reviewing.

BTW - We have a ton of FindBugs hits (well over 1000), so I'm only going
after the critical/scary ones (as categorized by findbugs.)


-Donald


On 6/22/10 10:52 AM, Pinaki Poddar wrote:
> 
> @@ -4621,7 +4621,7 @@ public class DBDictionary
>          // initialize the error codes
>          SQLErrorCodeReader codeReader = new SQLErrorCodeReader();
>          String rsrc = "sql-error-state-codes.xml";
> -        InputStream stream = getClass().getResourceAsStream(rsrc);
> +        InputStream stream = DBDictionary.class.getResourceAsStream(rsrc);
>          String dictionaryClassName = getClass().getName();
>          if (stream == null) { // User supplied dictionary but no error
> codes xml
>              // use default 
> 
> 
> It is likely that a user-defined database dictionary (which is not an
> extension but a new database type or somethiig) will carry its own error
> code. So first attempt to load that resource (sql-error-state-codes.xml), if
> none present, then load the default resource that is pre-packaged with
> OpenJPA libarray relative to DBDictionary.class.
> 
> -----
> Pinaki 

Mime
View raw message