openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Wolverton (JIRA)" <j...@apache.org>
Subject [jira] Created: (OPENJPA-1706) In JDBCStoreManager . connect method, should check if connection is closed
Date Wed, 23 Jun 2010 17:00:51 GMT
In JDBCStoreManager . connect method, should check if connection is closed
--------------------------------------------------------------------------

                 Key: OPENJPA-1706
                 URL: https://issues.apache.org/jira/browse/OPENJPA-1706
             Project: OpenJPA
          Issue Type: Bug
    Affects Versions: 2.0.0, 1.2.2
         Environment: We were using 1.2.2, but I see the same problem code in trunk.
            Reporter: David Wolverton
            Priority: Minor


The code currently reads:
// connect if the connection is currently null, or if
// the connection has been closed out from under us
if (_conn == null)
    _conn = connectInternal();

The comment indicates that it should check for null or closed, but the code only checks for
closed. Our application got to the state where connection was actually closed but not null.
We patched this with the following code to make it work:

if (_conn == null || _conn.isClosed())
    _conn = connectInternal();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message