Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: domain of curtisr7@gmail.com designates
 74.125.83.46 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=W9iUeOoZiIe2niDJB7BfFjoOx/Xw3TGruTQqjJ90mdNVB7Gz6ZlD9RJuv6x4OZT59J
         GLHfMuVG+dpjmXWaIMbAfh8ge7BCW9wZ42ztCe7E7TY7sMWyePbv3JaagMvASBdNmr7D
         s5FYo6DrsbwhPyRYpfk5PbjpFubpYV59VZdhs=
MIME-Version: 1.0
In-Reply-To: <x2j8e68c8e91004081333ub7300d56wc06876051f2fbe1c@mail.gmail.com>
References: <1127167746.587951269981987253.JavaMail.jira@brutus.apache.org>
	 <560293077.19101270753656664.JavaMail.jira@brutus.apache.org>
	 <x2j8e68c8e91004081333ub7300d56wc06876051f2fbe1c@mail.gmail.com>
Date: Thu, 8 Apr 2010 15:44:47 -0500
Message-ID: <g2xf8b633141004081344nb9143d0bu4e6633180da50e72@mail.gmail.com>
Subject: Re: [jira] Updated: (OPENJPA-1604) Setting PessimisticLockManager
	fails to append "for update clause" to the select statement
From: Rick Curtis <curtisr7@gmail.com>
To: dev@openjpa.apache.org
Content-Type: multipart/alternative; boundary=001e680f0a4cd9acd50483bfbf70

--001e680f0a4cd9acd50483bfbf70
Content-Type: text/plain; charset=ISO-8859-1

Albert -

When I committed the code I changed the trace string to localized warning
messages, but this brings up a very good point.

I know there is precedence for localizing trace messages, but does that mean
it is the right thing to do? Personally, I like putting trace in my code so
I can actually figure out what is going on if I have to debug a problem
after the fact. Requiring a developer to localize all trace messages is a
burden and in turn reduces the likely hood that someone trace will end up in
our code. As it is today, it is nearly impossible to fix most OpenJPA
problems on trace alone. Thoughts? ... I've been meaning to throw this one
out to the group for discussion.

-- 
Thanks,
Rick

On Thu, Apr 8, 2010 at 3:33 PM, Albert Lee <allee8285@gmail.com> wrote:

> Please localized the trace message.
>
> Thanks
> Albert Lee.
>
> On Thu, Apr 8, 2010 at 2:07 PM, Rick Curtis (JIRA) <jira@apache.org>
> wrote:
>
> >
> >     [
> >
> https://issues.apache.org/jira/browse/OPENJPA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Rick Curtis updated OPENJPA-1604:
> > ---------------------------------
> >
> >     Attachment: OPENJPA-1604-2.0.x.patch
> >                OPENJPA-1604-trunk.patch
> >
> > > Setting PessimisticLockManager fails to append "for update clause" to
> the
> > select statement
> > >
> >
> ------------------------------------------------------------------------------------------
> > >
> > >                 Key: OPENJPA-1604
> > >                 URL:
> https://issues.apache.org/jira/browse/OPENJPA-1604
> > >             Project: OpenJPA
> > >          Issue Type: Bug
> > >    Affects Versions: 2.0.0, 2.1.0
> > >            Reporter: Fay Wang
> > >            Assignee: Pinaki Poddar
> > >             Fix For: 2.0.0, 2.1.0
> > >
> > >         Attachments: OPENJPA-1604-2.0.x.patch, OPENJPA-1604-trunk.patch
> > >
> > >
> > >  I ran a testcase against openjpa 1.2, and found that the "for update"
> > clause is appended to the SQL when
> > >               <property name="openjpa.LockManager"
> value="pessimistic"/>
> > >       is added to the persistence.xml without calling:
> > >                q.setLockMode(LockModeType.PESSIMISTIC_WRITE);
> > > However, this behavior changes when running against trunk level code
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
>
> --
> Albert Lee.
>

--001e680f0a4cd9acd50483bfbf70--