openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pinaki Poddar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1628) Output control for generated canonical metamodel source code
Date Mon, 12 Apr 2010 14:28:40 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855981#action_12855981
] 

Pinaki Poddar commented on OPENJPA-1628:
----------------------------------------

Thanks Frank for the patch. I agree that the usage of existing "-s" or "-d" option to javac
is the proper way to control the output rather than a redundant -Aout flag. As far as I recall,
however, the values of -s/-d switches were not available consistently within the annotation
processing environment -- but I admit that I did not pay enough attention or research sufficiently
to output control at the time of writing the processor. 

I will prefer to apply your patch. Will you please update us on which compilers have you tried
the patch with? 

> Output control for generated canonical metamodel source code
> ------------------------------------------------------------
>
>                 Key: OPENJPA-1628
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1628
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jpa
>    Affects Versions: 2.0.0-beta3
>            Reporter: Frank Schwarz
>         Attachments: OPENJPA-1628.patch
>
>
> I think, the way the JPA metamodel generator places the generated Java files, is flawed.
I would have reopened OPENJPA-1187, if I had been able to.
> There should be no need to specify a proprietary switch ("openjpa.out") to specify the
output dir. There is a switch '-s' to be used with javac to specify the output directory of
the generated source files; see http://java.sun.com/javase/6/docs/technotes/tools/windows/javac.html.
A proprietary switch should only be used as a fallback option for inconsistent java-implementations.
> Furthermore, the current approach does not play well with eclipse IDE annotation processing.
The generated source files are placed under the eclipse installation directory. I can only
prevent this, if I specify a fully qualified "out"-path. This is not feasible, as a project
with these settings might be checked out to everywhere.
> The current approach with "setSourceOutputDirectory(new File(outDir))" seams only to
be working by coincidence with relative paths (e.g with ant-javac).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message