openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Catalina Wei (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1634) Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
Date Tue, 20 Apr 2010 21:19:49 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859068#action_12859068
] 

Catalina Wei commented on OPENJPA-1634:
---------------------------------------

1. NULL pointer check for 'cls'  the following code block:

+        // Preload XML MetaData
+        for(Class<?> cls : loaded){
+            ClassMetaData cmd = getCachedMetaData(cls);
+            getXMLMetaData(cls);
+            for(FieldMetaData fmd : cmd.getFields()){
+                getXMLMetaData(fmd.getDeclaredType());
+            }
+        }

2. please verify the patch passes JUnit test TestXMLCustomerOrder in org.apache.openjpa.persistence.xmlmapping.query.
    I can not recall the rational behaind the  method signature of 
         getXMLMetaData(FieldMetaData fmd) in AbstractExpresionBuilder.traversePath() 

If twith the path,  TestXMLCustomerOrder passes, then it is OK to change the method signiture.

> Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
> ---------------------------------------------------------------------------------
>
>                 Key: OPENJPA-1634
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1634
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: kernel
>            Reporter: Rick Curtis
>            Assignee: Rick Curtis
>         Attachments: OPENJPA-1634.patch
>
>
> This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this
JIRA will be used to fix the root problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message