openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Created: (OPENJPA-1581) getCache() should throw IllegalStateException if the EMF has been closed.
Date Thu, 18 Mar 2010 14:30:27 GMT
getCache() should throw IllegalStateException if the EMF has been closed. 
--------------------------------------------------------------------------

                 Key: OPENJPA-1581
                 URL: https://issues.apache.org/jira/browse/OPENJPA-1581
             Project: OpenJPA
          Issue Type: Bug
            Reporter: Michael Dick
            Assignee: Michael Dick
            Priority: Minor
             Fix For: 2.0.0


Per javadoc for EntityManagerFactory.getCache(): 

 /**

     * Access the cache that is associated with the entity manager 

     * factory (the "second level cache").

     * @return instance of the Cache interface

     * @throws IllegalStateException if the entity manager factory

     * has been closed

     */

    public Cache getCache();

Throwing a new IllegalStateException is trivial, but throwing the same exception we do for
other operations on a closed factory is a bit more involved. 

Short reason : 
* BrokerFactory.assertOpen() is not public, and the saved exception (used when trace is enabled)
is also not available outside of AbstractBrokerFactory. 
* EMFImpl.getCache() caches the cache. The same object implements the JPA cache interface
and the OpenJPA StoreCache interface. Historically getting the StoreCache does not require
the EMF to be open (this may be an oversight). 




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message