Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 41673 invoked from network); 12 Feb 2010 17:41:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Feb 2010 17:41:17 -0000 Received: (qmail 53599 invoked by uid 500); 12 Feb 2010 17:41:17 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 53545 invoked by uid 500); 12 Feb 2010 17:41:17 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 53535 invoked by uid 99); 12 Feb 2010 17:41:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2010 17:41:17 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of plinskey@gmail.com designates 72.14.220.152 as permitted sender) Received: from [72.14.220.152] (HELO fg-out-1718.google.com) (72.14.220.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2010 17:41:08 +0000 Received: by fg-out-1718.google.com with SMTP id l26so122229fgb.9 for ; Fri, 12 Feb 2010 09:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=/BzYSQjchF/QEt5HPdHBa5U6ldVinq49OZDVsOrVLIk=; b=a9jvPhWJ4HIkRIxZAe8kq8kXNOUWwola0+ZkblmGtAdYfpKRKw+5tunCoR3Ud2RTCb 3jT8e7SkIMVhQQ+uE0/94QznqbleKdR8mkouO9gtT0/OEgaADXuENLZuB76FcNcQlEwQ 2NNejTsusTOe/kSIATfkZ76pNPKGbkOt77Z4g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=x049U68ZLo5Sy31EEqROiUsii6q0pCVhjqIoqPftZqo7SRs8pJQPYrlS7vUhc/DoUF XLsKXJaGbzw1l6wT9ZTCr2HXCah9rmYuDq9POwIX53T/cfxy0psMyyoE9xVcIT5oDR9T E4wSASjE7Pd+kJI1O2JL5EBm33w7/EL2yFuQo= Received: by 10.87.35.15 with SMTP id n15mr3259244fgj.14.1265996446623; Fri, 12 Feb 2010 09:40:46 -0800 (PST) Received: from ?192.168.1.121? (c-69-181-104-186.hsd1.ca.comcast.net [69.181.104.186]) by mx.google.com with ESMTPS id 13sm1844014fxm.1.2010.02.12.09.40.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Feb 2010 09:40:44 -0800 (PST) Message-Id: <4AFC2A9B-FB31-4C76-BB5D-24ADB5AECBDC@gmail.com> From: Patrick Linskey To: dev@openjpa.apache.org In-Reply-To: <4B755808.6040008@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: openjpa.jdbc.QuerySQLCache property Date: Fri, 12 Feb 2010 09:40:40 -0800 References: <1265923813904-4557587.post@n2.nabble.com> <35801EFA-62B5-4B91-95C6-96E18E5D1BCB@gmail.com> <4B755808.6040008@apache.org> X-Mailer: Apple Mail (2.936) Cool, thanks, committed. -Patrick On Feb 12, 2010, at 5:30 AM, Donald Woods wrote: > The 1.3.x branch and Trunk are open for commits, while 1.0.x and 1.2.x > require approval from Mike Dick as the release manager. > > I took a quick look at the 1507 patch and it looks good to me. > > > -Donald > > > On 2/11/10 10:28 PM, Patrick Linskey wrote: >> Cool... I think that it might be possible to do some sort of >> deprecation. I'll take a look one of these days. >> >> Meanwhile, how are we committing fixes these days? I've got a fix for >> OPENJPA-1507; what's the process? >> >> -Patrick >> >> On Feb 11, 2010, at 1:30 PM, Pinaki Poddar wrote: >> >>> >>> Actually openjpa.jdbc.QuerySQLCache is a poor naming choice. That >>> name >>> openjpa.jdbc.QuerySQLCache originated from a rationale that the >>> currently >>> existing technique is a replacement of a previous implementation. >>> But >>> that >>> rationale is technically incorrect. >>> >>> I had preferred and proposed a more appropriate name such as >>> openjpa.PreparedQueryCache (without any jdbc reference to the name >>> -- >>> because technically the current implementation is a kernel-aware >>> artifact -- >>> with a JDBC specific implementation). But I had not been able to >>> find a >>> solution without replacing/removing the previous implementation >>> altogether, >>> and hence to concede that poor naming suggestion. Caching >>> technique/stratgey >>> used for the latest implementation is so very different than the >>> previous >>> one that considering it as replacement will be a factual error. >>> >>> >>> >>> >>> >>> ----- >>> Pinaki >>> -- >>> View this message in context: >>> http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4557587.html >>> >>> Sent from the OpenJPA Developers mailing list archive at Nabble.com. >> -- Patrick Linskey 202 669 5907