From dev-return-15285-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Thu Feb 25 17:24:48 2010 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 43512 invoked from network); 25 Feb 2010 17:24:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 Feb 2010 17:24:48 -0000 Received: (qmail 3709 invoked by uid 500); 25 Feb 2010 17:24:48 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 3686 invoked by uid 500); 25 Feb 2010 17:24:48 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 3678 invoked by uid 99); 25 Feb 2010 17:24:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2010 17:24:48 +0000 X-ASF-Spam-Status: No, hits=-1997.2 required=10.0 tests=ALL_TRUSTED,WEIRD_QUOTING X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2010 17:24:47 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D13E9234C045 for ; Thu, 25 Feb 2010 09:24:27 -0800 (PST) Message-ID: <1765318963.529101267118667842.JavaMail.jira@brutus.apache.org> Date: Thu, 25 Feb 2010 17:24:27 +0000 (UTC) From: "Laird Nelson (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-1537) SchemaGenerator interacts poorly with InformixDictionary (regression from 1.2.2) In-Reply-To: <629568646.526821267113148210.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OPENJPA-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838431#action_12838431 ] Laird Nelson commented on OPENJPA-1537: --------------------------------------- Sure, Jeremy. IMHO--and granted it's very, very H since I don't know the codebase--two identifiers should be equal to each other when their delimiters are removed. That would solve what I suspect will be a whole class of errors. That is, if "informix" were equal to informix. Trimming and whitespace are a little more difficult--although my naive suspicion here is that *identifiers* with trailing spaces don't exist. If my suspicion is correct, then we might be able to solve this by also saying that two identifiers are equal when their delimiters-removed, trimmed names are equal. That is, "informix " should equal informix. (I'm going to file some more bugs related to what happens when an identifier produced by the DBDictionary makes its way into an XML schema output by XMLSchemaSerializer. Hint: you get things like , which, after reverse mapping, ends up as: @Column(name=""foobar_column""), which doesn't compile. Are you the guy who will get these as well?) > SchemaGenerator interacts poorly with InformixDictionary (regression from 1.2.2) > -------------------------------------------------------------------------------- > > Key: OPENJPA-1537 > URL: https://issues.apache.org/jira/browse/OPENJPA-1537 > Project: OpenJPA > Issue Type: Bug > Components: jdbc, sql > Affects Versions: 2.0.0-beta > Reporter: Laird Nelson > Assignee: Jeremy Bauer > > If you ask the SchemaGenerator to generate schemas like this: > sg.generateSchemas(new DBIdentifier[] { DBIdentifier.newTable("informix.foobar_table") }); > ...then identifiers within the SchemaGenerator--whether of tables, primary keys, foreign keys, what have you--contain quotes. > Quoted identifiers are then subsequently not trimmed, because the space padding occurs inside the quotes. > This means the SchemaGroup will, for example, never find the Schema identified by the user at generateSchemas()-call-time. Consequently no foreign keys will be generated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.