openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Linskey <plins...@gmail.com>
Subject Re: openjpa.jdbc.QuerySQLCache property
Date Fri, 12 Feb 2010 17:40:40 GMT
Cool, thanks, committed.

-Patrick

On Feb 12, 2010, at 5:30 AM, Donald Woods wrote:

> The 1.3.x branch and Trunk are open for commits, while 1.0.x and 1.2.x
> require approval from Mike Dick as the release manager.
>
> I took a quick look at the 1507 patch and it looks good to me.
>
>
> -Donald
>
>
> On 2/11/10 10:28 PM, Patrick Linskey wrote:
>> Cool... I think that it might be possible to do some sort of
>> deprecation. I'll take a look one of these days.
>>
>> Meanwhile, how are we committing fixes these days? I've got a fix for
>> OPENJPA-1507; what's the process?
>>
>> -Patrick
>>
>> On Feb 11, 2010, at 1:30 PM, Pinaki Poddar wrote:
>>
>>>
>>> Actually openjpa.jdbc.QuerySQLCache is a poor naming choice. That  
>>> name
>>> openjpa.jdbc.QuerySQLCache originated from a rationale that the  
>>> currently
>>> existing technique is a replacement of a previous implementation.  
>>> But
>>> that
>>> rationale is technically incorrect.
>>>
>>> I had preferred and proposed a more appropriate name such as
>>> openjpa.PreparedQueryCache (without any jdbc reference to the name  
>>> --
>>> because technically the current implementation is a kernel-aware
>>> artifact --
>>> with a JDBC specific implementation). But I had not been able to  
>>> find a
>>> solution without replacing/removing the previous implementation
>>> altogether,
>>> and hence to concede that poor naming suggestion. Caching
>>> technique/stratgey
>>> used for the latest implementation is so very different than the  
>>> previous
>>> one that considering it as replacement will be a factual error.
>>>
>>>
>>>
>>>
>>>
>>> -----
>>> Pinaki
>>> -- 
>>> View this message in context:
>>> http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4557587.html
>>>
>>> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>>

-- 
Patrick Linskey
202 669 5907


Mime
View raw message