From dev-return-14227-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Thu Nov 12 20:31:04 2009 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 47132 invoked from network); 12 Nov 2009 20:31:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Nov 2009 20:31:04 -0000 Received: (qmail 41778 invoked by uid 500); 12 Nov 2009 20:31:03 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 41720 invoked by uid 500); 12 Nov 2009 20:31:03 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 41552 invoked by uid 99); 12 Nov 2009 20:31:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2009 20:31:03 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2009 20:31:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BDDCB234C4BB for ; Thu, 12 Nov 2009 12:30:39 -0800 (PST) Message-ID: <2025734070.1258057839776.JavaMail.jira@brutus> Date: Thu, 12 Nov 2009 20:30:39 +0000 (UTC) From: "Ravi P Palacherla (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-1051) [patch] Mappingtool doesn't check name conflicts if MappingDefaultsImpl is called with multiple columns. In-Reply-To: <1389484109.1240935210469.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777166#action_12777166 ] Ravi P Palacherla commented on OPENJPA-1051: -------------------------------------------- Hi Pinaki, Thanks for your suggestions. After reviewing your comments, I agree that the current solution is a bit complex and will try to work on the solution you suggested. Regards, Ravi. > [patch] Mappingtool doesn't check name conflicts if MappingDefaultsImpl is called with multiple columns. > -------------------------------------------------------------------------------------------------------- > > Key: OPENJPA-1051 > URL: https://issues.apache.org/jira/browse/OPENJPA-1051 > Project: OpenJPA > Issue Type: Bug > Components: jdbc > Affects Versions: 1.0.0, 2.0.0-M2 > Environment: OpenJPA Trunk. > Reporter: Ravi P Palacherla > Assignee: David Ezzio > Fix For: 1.1.1, 2.0.0-M2 > > Attachments: OPENJPA-1051_Trunk.patch > > > In OpenJPA implementation, it looks that MappingDefaultsImpl.populateColumns can accept multiple columns > because it has Column[] signature. > If column name is longer than DBDictionary restriction (it's very short in some databases. > For example, oracle max name length is 32), names are truncated. > > Because name conflict is detected based on actual Table info,given Column[] data does not get checked. > So, if given Column[] have very long name and truncated name of these Column[] is conflicted, > it could not be detected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.