From dev-return-14010-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Thu Oct 15 13:28:27 2009 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 6303 invoked from network); 15 Oct 2009 13:28:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Oct 2009 13:28:27 -0000 Received: (qmail 3634 invoked by uid 500); 15 Oct 2009 13:28:27 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 3568 invoked by uid 500); 15 Oct 2009 13:28:26 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 3558 invoked by uid 99); 15 Oct 2009 13:28:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2009 13:28:26 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of michael.d.dick@gmail.com designates 209.85.220.206 as permitted sender) Received: from [209.85.220.206] (HELO mail-fx0-f206.google.com) (209.85.220.206) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2009 13:28:18 +0000 Received: by fxm2 with SMTP id 2so1117705fxm.28 for ; Thu, 15 Oct 2009 06:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type; bh=PD4SzVNe3i3v1Wg8d4E32CokqxX/pWmhfPvMpl7DH4M=; b=ubPT6D/vmx7R5u+PRWudLyqtKfzz9NBrov/uuiCJP4+sPJw4R5jPZvbye8/yfaCz+V dL6sP8hb1KVE27sl7qsL4MRGvMBoPLIjzCcdQb2n7moXmSZEaDwwc/UgrTwRLuogAl5u B7n93sOBueE8w5mulGIFgEdPNLYezbVc3n2MY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=p/Z6xbu7YgoOodD3VA1rJMuMmWGWJeKDrLPcf1ZB/IZn349uYgOW/8DvuMa5Sd2RfX VHe+ur7+G95vQ2ZlWO6sdAFRTHQ+ttn62G8Y6OFARxTjvPbWxfGK6bleZzbbcEd8YSLz xWGGOvVH7U//t5b/bL1nVxJ0aSbFYVwL/nWCM= MIME-Version: 1.0 Received: by 10.204.34.201 with SMTP id m9mr44956bkd.77.1255613278155; Thu, 15 Oct 2009 06:27:58 -0700 (PDT) In-Reply-To: <20091014150958.DD39423888E3@eris.apache.org> References: <20091014150958.DD39423888E3@eris.apache.org> From: Michael Dick Date: Thu, 15 Oct 2009 08:27:38 -0500 Message-ID: <72c1350f0910150627p52d13958g960ec70a7fa6405f@mail.gmail.com> Subject: Re: svn commit: r825161 - /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/writebehind/crud/TestEmbeddable.java To: dev@openjpa.apache.org Content-Type: multipart/alternative; boundary=0003255550f26b73620475f93f99 X-Virus-Checked: Checked by ClamAV on apache.org --0003255550f26b73620475f93f99 Content-Type: text/plain; charset=ISO-8859-1 Hi Tim, I'd actually rather have the testcase commented out if we know it's going to fail. @AllowFailure still runs the test so the builds take longer and it _looks_ like we have another passing testcase. Is there a compelling reason to run the test even though we expect it to fail? Maybe this is just my personal pet peeve. -mike On Wed, Oct 14, 2009 at 10:09 AM, wrote: > Author: mcconne > Date: Wed Oct 14 15:09:58 2009 > New Revision: 825161 > > URL: http://svn.apache.org/viewvc?rev=825161&view=rev > Log: > OPENJPA-1348 Use @AllowFailure annotation rather than commenting out > failing testcase > > Modified: > > openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/writebehind/crud/TestEmbeddable.java > > Modified: > openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/writebehind/crud/TestEmbeddable.java > URL: > http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/writebehind/crud/TestEmbeddable.java?rev=825161&r1=825160&r2=825161&view=diff > > ============================================================================== > --- > openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/writebehind/crud/TestEmbeddable.java > (original) > +++ > openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/writebehind/crud/TestEmbeddable.java > Wed Oct 14 15:09:58 2009 > @@ -25,6 +25,7 @@ > import org.apache.openjpa.jdbc.writebehind.entities.Entity02; > import org.apache.openjpa.persistence.OpenJPAEntityManagerFactorySPI; > import org.apache.openjpa.persistence.OpenJPAEntityManagerSPI; > +import org.apache.openjpa.persistence.test.AllowFailure; > import org.apache.openjpa.persistence.test.SingleEMFTestCase; > import org.apache.openjpa.writebehind.WriteBehindCache; > import org.apache.openjpa.writebehind.WriteBehindCacheManager; > @@ -123,7 +124,8 @@ > * > * @exception Exception > */ > -/* public void testEntity01ManualFlush() { > + @AllowFailure(value=true, message="See OPENJPA-1348") > + public void test_Entity01_Manual_Flush() { > > // > // Create a new instance of the entity/embeddable class > @@ -181,10 +183,10 @@ > assertEquals(findEntity01.getEnt01_int01(), 1); > assertEquals(findEntity01.getEnt01_int02(), 2); > assertEquals(findEntity01.getEnt01_int03(), 3); > - assertEquals(fndEntity01.getEmb01_int01(), 4); > + assertEquals(findEntity01.getEmb01_int01(), 4); > assertEquals(findEntity01.getEmb01_int02(), 5); > assertEquals(findEntity01.getEmb01_int03(), 6); > - } */ > + } > > > /** > @@ -192,7 +194,7 @@ > * > * @exception Exception > */ > - public void testEntity02ManualFlush() { > + public void test_Entity02_Manual_Flush() { > > // > // Create a new instance of the entity class > > > --0003255550f26b73620475f93f99--