Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: domain of mtylenda@o2.pl designates
 193.17.41.16 as permitted sender)
Subject: =?UTF-8?Q?Re:_New_o-p-j_TestCase_methods?=
From: =?UTF-8?Q?Mi=C5=82osz_Tylenda?= <mtylenda@o2.pl>
To: dev@openjpa.apache.org
In-Reply-To: <4AA93480.9030204@apache.org>
References: <4AA93480.9030204@apache.org>
Mime-Version: 1.0
Message-ID: <2e116005.65cf692b.4aacd3fb.c7546@o2.pl>
Date: Sun, 13 Sep 2009 13:14:03 +0200
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi=20Donald,

I=20like=20your=20idea=20of=20specifying=20(un)supportedDatabases,=20was=20=
also=20thinking=20about=20something=20like=20this.

There=20is=20a=20small=20issue=20however.=20When=20you=20run=20TestMultip=
leSchemaNames=20with=20PostgreSQL,=20it=20fails=20in=20setUp.=20This=20is=
=20because=20the=20setUnsupportedDatabases=20creates=20an=20EntityManager=
=20which=20in=20turn=20tries=20to=20create=20tables=20for=20a=20schema=20=
not=20yet=20created.=20PostgreSQL=20requires=20a=20schema=20being=20creat=
ed=20up-front=20and=20this=20is=20what=20createSchemas=20method=20does.

I=20suggest=20we=20either:
1.=20Modify=20the=20set(Un)supportedDatabases=20methods=20to=20not=20crea=
te=20EntityManager.=20It=20is=20possible=20to=20determine=20the=20instanc=
e=20of=20DBDictionary=20just=20from=20OpenJPAEntityManagerFactory(SPI).=20=
That=20would=20also=20have=20some=20minor=20positive=20performance=20impa=
ct.=20An=20EntityManager=20would=20be=20needed=20if=20we=20wanted=20DBDic=
tionary=20properties=20be=20initialized=20from=20a=20connection=20(see=20=
TestXMLCustomerOrder=20for=20example).

2.=20If=20for=20some=20reason=20the=20above=20is=20wrong,=20let's=20just=20=
try=20to=20move=20createSchemas=20call=20before=20setUnsupportedDatabases=
=20call.

Regards,
Milosz


>=20Some=20updates=20I=20just=20checked=20into=20trunk=20as=20r813506=20a=
nd=20r813519=20under=20
>=20openjpa-persistence-jdbc=20which=20should=20make=20writing=20and=20ma=
intaining=20
>=20testcases=20easier...
>=20
>=20For=20setUp()=20code=20(all=20can=20be=20used=20before=20super.setUp(=
)=20is=20called):
>=20-=20Added=20new=20protected=20methods=20of=20setTestsDisabled()/isTes=
tsDisabled()=20in=20
>=20AbstractPersistenceTestCase=20which=20is=20used=20by=20runTest()=20to=
=20automatically=20
>=20skip=20all=20tests.=20=20This=20keeps=20us=20from=20having=20to=20put=
=20our=20own=20if(skipTests)=20
>=20in=20each=20testXXX=20method=20for=20most=20cases=20(unless=20you=20n=
eed=20granular=20per=20test=20
>=20exclusion=20capabilities).
>=20
>=20=20=20=20=20=20setTestsDisabled(!dictionarySupportsXMLColumn());
>=20=20=20=20=20=20if=20(isTestsDisabled())=20{
>=20=20=20=20=20=20=20=20=20=20return;
>=20=20=20=20=20=20}
>=20
>=20-=20Added=20new=20setSupportedDatabases()/setUnsupportedDatabases()=20=
methods=20in=20
>=20SingleEMFTestCase=20to=20set=20the=20testsDisabled=20flag=20in=20
>=20AbstractPersistenceTestCase,=20which=20allows=20you=20to=20exclude=20=
all=20tests=20based=20
>=20on=20the=20DB=20platform=20being=20used=20-
>=20
>=20=20=20=20=20=20setUnsupportedDatabases(
>=20=20=20=20=20=20=20=20=20=20org.apache.openjpa.jdbc.sql.MySQLDictionar=
y.class,
>=20=20=20=20=20=20=20=20=20=20org.apache.openjpa.jdbc.sql.OracleDictiona=
ry.class,
>=20=20=20=20=20=20=20=20=20=20org.apache.openjpa.jdbc.sql.SQLServerDicti=
onary.class);
>=20=20=20=20=20=20if=20(isTestsDisabled())=20{
>=20=20=20=20=20=20=20=20=20=20return;
>=20=20=20=20=20=20}
>=20
>=20
>=20For=20general=20usage:
>=20-=20Added=20a=20getLog()=20method=20in=20SingleEMFTestCase=20class=20=
for=20everyone=20to=20
>=20use,=20instead=20of=20having=20a=20copy=20in=20your=20own=20tests.=20=
=20Also,=20you=20can=20now=20use=20
>=20logging=20before=20calling=20super.setUp(),=20as=20the=20getLog()=20w=
ill=20create=20a=20
>=20temporary=20EMF=20if=20needed.
>=20
>=20
>=20
>=20-Donald
>=20