Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: local policy)
MIME-version: 1.0
Date: Mon, 27 Jul 2009 12:36:20 -0700
From: Craig L Russell <Craig.Russell@Sun.COM>
Subject: Re: Curious about subclassing rather than entity enhancement
In-reply-to: 
 <2EFDE7AD867BF346BA5130160871B9920CBE3A47@RHV-EXM-03.corp.ebay.com>
Sender: Craig.Russell@Sun.COM
To: dev@openjpa.apache.org
Message-id: <89104425-00FA-4321-8900-B8A87C86CF8A@SUN.com>
Content-type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha1; boundary=Apple-Mail-26--166758054
References: 
 <2EFDE7AD867BF346BA5130160871B9920CBE3806@RHV-EXM-03.corp.ebay.com>
 <0DD60B4C-91C2-40C6-954E-D6263735465C@SUN.com>
 <2EFDE7AD867BF346BA5130160871B9920CBE3A47@RHV-EXM-03.corp.ebay.com>

--Apple-Mail-26--166758054
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit

Hi Mike,

On Jul 27, 2009, at 12:07 PM, Yawn, Mike wrote:

> Hi Craig,
>
> Thanks for the details ... see below
>
>> -----Original Message-----
>> From: Craig.Russell@Sun.COM [mailto:Craig.Russell@Sun.COM]
>> Sent: Monday, July 27, 2009 10:06 AM
>> To: dev@openjpa.apache.org
>> Subject: Re: Curious about subclassing rather than entity enhancement
>>
>> Hi Mike,
>>
>> On Jul 27, 2009, at 8:45 AM, Yawn, Mike wrote:
>>
>>>
>>>
>>> I'm curious about something I read on the 'Entity Enhancement' page.
>>> Currently, our "JPA-like" implementation of annotations uses the
>>> standard JPA annotations, but on an interface rather than a class.
>>
>> This is a very common (good) pattern for persistence.
>
> [Yawn, Mike] But one that seems to be expressly prohibited by JPA spec
> (Section 2.1, "The entity class must be a top-level class. An enum or
> interface must not be designated as an entity.".   Does OpenJPA allow
> this?

Yes. See 5.3 of the OpenJPA manual "Managed Interfaces".

> (If not currently, and we made modifications to work with
> interfaces, would OpenJPA be interested in this code or should we plan
> to keep it in our own branch?)
>
>>
>>> Then, our code generation generates the implementation classes from
>>> the
>>> interface; we don't ever add or modify code behind the user's back,
> so
>>> all the implementation code is fully visible.
>>
>> So you need a factory to allow the user to create a new instance of
>> the implementation class. How do you tell the user what to "new", or
>> perhaps you have a factory with a method like <T> T
>> newInstance(Class<T> interface)?
>
> [Yawn, Mike] We have a DAO class that provides basic lifecycle
> functionality (insert, update, delete, findByPK, plus user-added
> queries).  The DAO also provides a createLocal() method that returns a
> non-persistent (local) data object that can later be passed to the
> 'insert' method.   The return type of createLocal is the entity
> interface, and what we return is the implementation class with all of
> the state tracking, etc.  So our EntityManager methods would mostly be
> calling the DAO.
>
>>> On the entity enhancement page, there is a statement that "Some JPA
>>> providers auto-generate new subclasses or proxy objects that front  
>>> the
>>> user's Entity objects at runtime" ...., and I'm curious how this  
>>> works
>>> given that it seems that the mechanism for creating an entity object
>>> is to call "new" on it.
>>
>> This is how users create an entity to persist. But once it's
>> persisted, the provider has its own factory that it uses when  
>> fetching
>> instances from the database.
>
> [Yawn, Mike] persist doesn't return an object to the caller -- once an
> object is initially persisted, can the user continue to work with that
> object (modify fields), or do they need to retrieve the object from  
> the
> EntityManager first?  Because in the first case I don't see how the
> implementation can be detecting any state changes to the object.

There are some corner cases if you persist an entity, flush it to the  
database, and then continue to modify it. But if you persist and  
commit, these issues go away. After commit, the instance is detached  
and you need to reacquire the persistent instance from the entity  
manager.

Craig
>
>>> So, if there is a JPA-annotated class that
>>> represents the entity, and then a JPA implementer creates a subclass
>>> of
>>> this to provide loaded / dirty tracking, etc., it seems that any
>>> instantiation of the Entity via "new"  would be getting the  
>>> annotated
>>> base class, not the subclass with the implementation of these
>>> features.
>>
>> Right.
>>
>>> How is that being handled in JPA implementations that use subclasses
>>> rather than byte-code weaving ?
>>
>> Byte-code enhancement is done primarily to allow detection of  
>> changes,
>> which by definition isn't needed for new instances (all fields are
>> considered changed for newly persisted instances).
>>
>> Craig
>>>
>>>
>>>
>>>
>>>
>>> Thanks,
>>>
>>> Mike Yawn
>>>
>>> eBay Inc.
>>>
>>
>> Craig L Russell
>> Architect, Sun Java Enterprise System http://db.apache.org/jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>
> [Yawn, Mike] Hmm, that P.S. looks anagram-y but I can't decipher it.
>
> Mike

Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


--Apple-Mail-26--166758054
Content-Disposition: attachment;
	filename=smime.p7s
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw
ggJyoAMCAQICEDXZ+Ig/3d9DjJZ8u++ZnC0wDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx
JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTE4MTYwMloXDTA5MTIwOTE4MTYw
MlowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny
YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC
ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOe3oksetTgSiqqWllhIYBT0dWhR4CitzXDf
+ETyrtEF2HWRRpfwixLpV1Az8wwFzNKfjvQn3tQh0A/VDDeepDEM9TKLP+D6qShLR/KTf5kCMyT4
mILJYIDo/JMmTIH5jceojvlTDFd0gd+XXNAGGz1Wu2XxfvFDE/lpFnQkKYE+VjjENONy4JlkJnOI
rSfMlb+zHPAUmMTtmhxYIDLgov4Jv2Z5pUKZMpNcYr+7jJeUxkxKwWm4im56h7CGP0Yhkq2Je506
mqKCFImxofBjkHZISVS5m7WaGs4lViDtwLQEPtyUt7RcaoYWTvEQtvoy1TE2oZDUaAYFxVu0cHUW
bU0CAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC
MAAwDQYJKoZIhvcNAQEFBQADgYEAQaqAADs5GLyk9iO1xfmNFySpOXXofJPEbfbt77BK/WLhLOwS
69WIxSmGMpGGUlLd6FJ1xfLzsvP9/N5tmZQlpGcBoEwrn830JcbNyEG0ANcmdeAy2yBjNjWoIDhV
QmQw8OgJDk0xi0Tv/UYm9uPxOhDJOA67a3v6FHvSAbLqBScwggM/MIICqKADAgECAgENMA0GCSqG
SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH
EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp
Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h
aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw
NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl
IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls
IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE
cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef
kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB
AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js
LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD
VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB
AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+
hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC
3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0ECEDXZ+Ig/3d9DjJZ8u++ZnC0wCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN
AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDkwNzI3MTkzNjIxWjAjBgkqhkiG9w0B
CQQxFgQUUPdXQK+c5BQi/e6s+HGdTo66zYAwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC
WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0
ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA12fiIP93fQ4yWfLvvmZwtMIGHBgsqhkiG
9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ
dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA1
2fiIP93fQ4yWfLvvmZwtMA0GCSqGSIb3DQEBAQUABIIBAEBnKUBT1DnqNUxxdlojjauQvz0pG6eo
tZy4wgr+0qdy81RjzrqD66H/xg5tOXnpiP5qz+XLsAkkxUHsD+80eH/z8gQVQZGC0E1ALMXNJu0I
vQ7vgMeOD2jLTX/9M4svG1f6RKy30NvoT4hxoGnqDcGLFGz6hMqUxUDqgElTnxncZe1uXoizzVdx
iE1brVajSfJmo6WNQWxtbu1A/GsB9LABTj81n6+awFoWRpmB/oxiusfyFDeR7vcZE5upZCWXGLln
Pgule2hCN0L5Zwech4q5ieAI+klO1ifbgMfKWdaqO0tk0wKHpZIt61O/pvgF5wWlSfI5UHP3aRxP
K/Pa4gQAAAAAAAA=

--Apple-Mail-26--166758054--