openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From i...@dvholten.de
Subject Re: [jira] Commented: (OPENJPA-1118) code changes towards broader use of JDK5 features
Date Mon, 13 Jul 2009 07:17:35 GMT
Hello Michael,

thanks for  feedback. The whitespace-changes are collateral damage done by 
my IDE.
It strips trailing blanks when saving. However, i think, i can split that:
- find those files which contain some x.valueOf() or StringBuffer or else 
thing
- create a 'whitespace'-patch for these
- then create a 'content' - patch on top of this, which doesnt contain 
whitespace-changes.

greetings
dieter von holten





"Michael Dick (JIRA)" <jira@apache.org> 
11.07.2009 19:06
Please respond to
dev@openjpa.apache.org


To
dev@openjpa.apache.org
cc

Subject
[jira] Commented: (OPENJPA-1118) code changes towards broader use of JDK5 
features







    [ 
https://issues.apache.org/jira/browse/OPENJPA-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730007#action_12730007

] 

Michael Dick commented on OPENJPA-1118:
---------------------------------------

Hi Dieter,

Thanks for both of the patches, but this would be a lot easier for me to 
review if you made each type of change in a single patch. For example put 
the whitespace changes in one file, Numbers.valueOf() -> 
Byte/Short/Integer.valueOf() in another one, etc. 


> code changes towards broader use of JDK5 features
> -------------------------------------------------
>
>                 Key: OPENJPA-1118
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1118
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: dieter von holten
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: DvH090604a.diff, DvH090711Jira1118b.diff
>
>
> the current code of OpenJPA can be enhanced by:
> 1.) replacing Numbers.valueOf( int ) and Numbers.valueOf( long ) by 
their conunterparts in Integer and Long, as well as replacing new 
Integer/Byte/Short/Long/Character by their factory-methods
> 2.) replace StringBuffer by StringBuilder, replace .append( "x" ) by 
.append( 'x' ) where possible
> 3.) use more generics ( in Iterators, for example)
> attached is a patch which contains 1.) for the below openjpa-jdbc/..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message