openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1118) code changes towards broader use of JDK5 features
Date Sat, 11 Jul 2009 17:06:15 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730007#action_12730007
] 

Michael Dick commented on OPENJPA-1118:
---------------------------------------

Hi Dieter,

Thanks for both of the patches, but this would be a lot easier for me to review if you made
each type of change in a single patch. For example put the whitespace changes in one file,
Numbers.valueOf() -> Byte/Short/Integer.valueOf() in another one, etc. 


> code changes towards broader use of JDK5 features
> -------------------------------------------------
>
>                 Key: OPENJPA-1118
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1118
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: dieter von holten
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: DvH090604a.diff, DvH090711Jira1118b.diff
>
>
> the current code of OpenJPA can be enhanced by:
> 1.) replacing Numbers.valueOf( int ) and Numbers.valueOf( long ) by their conunterparts
in Integer and Long, as well as replacing new Integer/Byte/Short/Long/Character by their factory-methods
> 2.) replace StringBuffer by StringBuilder, replace .append( "x" ) by .append( 'x' ) where
possible
> 3.) use more generics ( in Iterators, for example)
> attached is a patch which contains 1.) for the below openjpa-jdbc/..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message