Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type;
  b=J2CHoqpIPydTelAPXCSScTy4b7Zlsk0OKqPwILV4ByjSCMBRA1fu/4dgvh87Lej4MKcvDa3KE6mFz5RWSGSFTrBjCxcN9sATDQ0Wx9idqNQQscRwikBRClZcT05h3/L8ElrRtVMFd2WvVJ/blvuFs9Uem3ikauN01eZR7bcPvnA=;
Message-ID: <665208.56308.qm@web55905.mail.re3.yahoo.com>
References: <20090626170104.BB06623888D0@eris.apache.org>
 <4E49352D-E43E-439E-BE62-A4DD417647A7@SUN.com>
Date: Fri, 26 Jun 2009 10:46:28 -0700 (PDT)
From: Fay Wang <fyw300@yahoo.com>
Subject: Re: svn commit: r788764 -
 /openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
To: dev@openjpa.apache.org
In-Reply-To: <4E49352D-E43E-439E-BE62-A4DD417647A7@SUN.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii


Thank you for the good catch! I fixed it now.


----- Original Message ----
From: Craig L Russell <Craig.Russell@Sun.COM>
To: dev@openjpa.apache.org
Sent: Friday, June 26, 2009 10:16:39 AM
Subject: Re: svn commit: r788764 - /openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java

Hi Fay,

This patch seems suspect. The cast doesn't match the expected return type. Or is PathImpl<?,?> assignment compatible with RootImpl<?>

I haven't studied this part of the specification...

Craig

On Jun 26, 2009, at 10:01 AM, faywang@apache.org wrote:

> Author: faywang
> Date: Fri Jun 26 17:01:04 2009
> New Revision: 788764
> 
> URL: http://svn.apache.org/viewvc?rev=788764&view=rev
> Log:
> OPENJPA-1143: fix compiler error for IBM SDK5
> 
> Modified:
>    openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
> 
> Modified: openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
> URL: http://svn.apache.org/viewvc/openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java?rev=788764&r1=788763&r2=788764&view=diff
> ==============================================================================
> --- openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java (original)
> +++ openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java Fri Jun 26 17:01:04 2009
> @@ -249,7 +249,7 @@
>     // should be the class metadata of the collection element
>     private ClassMetaData getCandidate() {
>         RootImpl<?> root = (RootImpl<?>)getRoot();
> -        RootImpl<?> correlatedRoot = (RootImpl<?>)root.getCorrelatedParent();
> +        PathImpl<?,?> correlatedRoot = (RootImpl<?>)root.getCorrelatedParent();
>         if (correlatedRoot != null && root.getJoins() != null) {
>            Join<?,?> join = root.getJoins().iterator().next();
>            FieldMetaData fmd = ((Members.Member<?, ?>)join.getAttribute()).fmd;
> 
> 

Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!