Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4A294E9A.1010405@apache.org>
Date: Fri, 05 Jun 2009 12:58:02 -0400
From: Donald Woods <dwoods@apache.org>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: dev@openjpa.apache.org
Subject: Re: 80-column line width & auto-generated model classes
References: <1244133496189-3025746.post@n2.nabble.com>
	 <915B5A2C-186E-4CD8-B569-C248FF35C795@SUN.com>
	 <1244208989974-3030320.post@n2.nabble.com>
	 <72c1350f0906050643g4ff8f1acs59badcd93a86a782@mail.gmail.com>
	 <1244215021459-3030904.post@n2.nabble.com>
 <72c1350f0906050944y7b3c352auec2eedee68b04e29@mail.gmail.com>
In-Reply-To: <72c1350f0906050944y7b3c352auec2eedee68b04e29@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Michael Dick wrote:
> On Fri, Jun 5, 2009 at 10:17 AM, Pinaki Poddar <ppoddar@apache.org> wrote:
> 
>> Hi Mike,
>>> Are the files generated during the build process or are they committed to
>>> SVN?
>> They are committed to SVN. Other Junit Test code needs them at
>> development/compile time.
>>
> 
> Why can't we run the tool to generate the code during the build? Ideally
> after running checkstyle, but if we can't do that then we can always disable
> the check.
> 

Agree.  Maybe by using the process-resource goal and antrun plugin?

But, I could also see where we would want a handful of these checked in, 
  as a test to compare what the mapping tool is creating versus what we 
expect.

> 
>>> I think they should comply before we commit them.
>> They are generated by an automatic source code writer. The writer/code
>> generator does not  have a notion of line length limit during output. To
>> enforce it via that code generator is neither trivial for the way it emits
>> different code elements nor I have bandwidth to invest. If compliance to
>> line length limit is paramount, then whichever issue (I still could not
>> find
>> that JIRA) is handling that task may take that up.
>>
> 
> I think that compliance to code conventions is paramount for anything we
> commit to SVN. What the line length is set to is debatable, but if it's
> committed then it should conform.
> 
> <snip>
> 
> -mike
>