openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig L Russell <Craig.Russ...@Sun.COM>
Subject Re: [VOTE]: Extend the source/test code line width to 120 chars
Date Thu, 18 Jun 2009 14:53:01 GMT
+1 for allowing up to 120 character lines.

-1 for reformatting existing lines by requirement

+1 for allowing developers to reformat oddly formatted lines when  
found during normal editing of files.

Craig

On Jun 18, 2009, at 7:26 AM, Michael Dick wrote:

> Sorry for following my own post.
>
> Someone (Rick) reported a problem with the link, apparently my sig was
> appended to the url.
>
> [1] http://source.android.com/submit-patches/code-style-guide
>
> Hopefully the link will work better this time. Regarding formatting, I
> really don't want to reformat all the source (again). I'd prefer to  
> stick
> with the Android convention of leaving existing files at 80  
> (unenforced by
> checkstyle), and new files can be 100 or 120 (enforced).
>
> Contrary to popular belief, I'm not trying to prolong this issue, I  
> just
> want to at least raise the concern now - before we make the change.
>
> -mike
>
> On Thu, Jun 18, 2009 at 9:15 AM, Michael Dick <michael.d.dick@gmail.com 
> >wrote:
>
>> Hi Pinaki,
>>
>> Before I vote I'd like to know what you propose to do for existing  
>> files?
>> Should they be reformatted, left as is with the occasional long  
>> line, or
>> should we preserve history (like Andriod [1])?
>>
>> I'd also like to propose 100 as the limit (120 makes three way  
>> diffs tricky
>> to fit on the screen). David Ezzio suggested 90 in the [DISCUSS]  
>> thread so
>> that might warrant consideration.
>>
>> [1] http://source.android.com/submit-patches/code-style-guide
>> -mike
>>
>>
>> On Thu, Jun 18, 2009 at 9:06 AM, Pinaki Poddar <ppoddar@apache.org>  
>> wrote:
>>
>>>
>>> Proposal to increase the line width limit to 120 chars from  
>>> existing 80
>>> chars.
>>>
>>> +1 : change it to 120 (or something greater than 80)
>>> -1 : keep it to 80 (or something less than 80)
>>> 0  : i do not care
>>>
>>>
>>>
>>>
>>> Reason: New API classes/methods have long names and often require  
>>> multiple
>>> generic parameters with bounds. 80-char line width is hampering
>>> readability
>>> than helping it.
>>>
>>>
>>>
>>> -----
>>> Pinaki
>>> --
>>> View this message in context:
>>> http://n2.nabble.com/-VOTE-%3A-Extend-the-source-test-code-line-width-to-120-chars-tp3113489p3113489.html
>>> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>>>
>>>
>>

Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message