openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Milosz Tylenda (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1122) Remove JDBC 3 related reflection from DBDictionary
Date Fri, 05 Jun 2009 16:04:07 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716657#action_12716657
] 

Milosz Tylenda commented on OPENJPA-1122:
-----------------------------------------

In fact, currently the putBytes,putString, putChars and invokePutLobMethod methods are not
used. They are used only when maxEmbedded*lobSize property is != 1. This is the case only
for OracleDictionary but that dictionary overrides the methods mentioned.

I would also change the signatures to specify actual LOB types instead of Object unless somebody
has an objection. For example

public void putBytes(Object blob, byte[] data)

would become

public void putBytes(Blob blob, byte[] data)


> Remove JDBC 3 related reflection from DBDictionary
> --------------------------------------------------
>
>                 Key: OPENJPA-1122
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1122
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.3.0, 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Minor
>
> The reflection on JDBC 3 LOB related methods in DBDictionary can be replaced with plain
method calls as we now require Java 5.
> A short discussion took place on the dev list [1].
> [1] http://n2.nabble.com/JDBC-3-reflection-in-DBDictionary-tp2965629p2965629.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message