openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1147) Streaming LOB tests and TestAutoIncrement not executed by test suite
Date Sun, 28 Jun 2009 20:34:47 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724995#action_12724995
] 

Michael Dick commented on OPENJPA-1147:
---------------------------------------

I like using instanceof on DBDictionary better than platform, as it verifies the target database
(ie goes through all the DBDictionary factory code) and doesn't require manual intervention.
Thanks for noticing this. 

> Streaming LOB tests and TestAutoIncrement not executed by test suite
> --------------------------------------------------------------------
>
>                 Key: OPENJPA-1147
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1147
>             Project: OpenJPA
>          Issue Type: Test
>          Components: build / infrastructure
>    Affects Versions: 1.1.0, 1.2.1
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Minor
>
> InputStreamLobTest and ReaderLobTest tests are not executed because their names end with
"Test". TestAutoIncrement is Oracle-specific but is not executed even against Oracle unless
you specify -Dplatform=oracle.
> Solution:
> 1. Rename streaming LOB tests to start with "Test".
> 2. Remove isTargetPlatform call from TestAutoIncrement since the test already has @DatabasePlatform("oracle.jdbc.driver.OracleDriver")
annotation.
> BTW, a similar issue is with TestOrderColumnXML.testOrderColumnColumnDefinition. It requires
to specify -Dplatform=... not to run it if the database is not Derby but I don't think our
database profiles do that. Maybe it's better to just use instanceof on DBDictionary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message