openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1015) Enforce 80-column line width for source code
Date Mon, 15 Jun 2009 18:06:07 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719675#action_12719675
] 

Michael Dick commented on OPENJPA-1015:
---------------------------------------

>> Anyone opposed to doing the tests as well?

>I am, at least temporarily.
>1. I am checking in auto-generated source code for meta-model classes in the test directories.
The program that >generates these source code do not understand char-width limit. Making
them smart in that respect is not >currently in my priority list. Till that is done any
policy in this regard should not block commit. 

Fixed now

>2. While everyone agrees on a limit, there is no agreement on 80 char per se. 

Please reply to dev@openjpa where this discussion was raised - this JIRA issue is resolved
and isn't the best place to carry on a discussion. 

>3. Test code had been kept out of width limit traditionally. This looks like a new policy.
Should be part of a >separate discussion than this one whose original purpose was to recognize
an *existing* policy.

Interesting, can you show me where we discussed excluding test code from the conventions?
I don't remember seeing that anywhere. 

>4. I see violation of other rules in source tree that are not checked now. If compliance
is the main goal that >focus should be increasing the variety of compliance rules on the
source tree rather than including Test 
>sources.

Go for it. But the rules should apply to all the source, not just main source. Test code needs
to be readable too. It provides a good starting point for many users. 


> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>            Assignee: B.J. Reed
>             Fix For: 2.0.0-M2
>
>         Attachments: line80.txt, OPENJPA-1015-audit-output.patch, OPENJPA-1015-checkstyle.xml.patch,
OPENJPA-1015-max80chars.patch, OPENJPA-1015-newlineendoffile.patch, OPENJPA-1015-plugin-version.patch,
OPENJPA-1015-test.patch, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message