openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pinaki Poddar <ppod...@apache.org>
Subject Re: [VOTE]: Extend the source/test code line width to 120 chars
Date Thu, 18 Jun 2009 15:07:22 GMT

Hi Mike,
  This change request does not imply any bulk reformatting of existing code.
However, if the change is approved by vote, then a developer is free to edit
existing code lines to improve readability.  


Michael Dick wrote:
> 
> Hi Pinaki,
> 
> Before I vote I'd like to know what you propose to do for existing files?
> Should they be reformatted, left as is with the occasional long line, or
> should we preserve history (like Andriod [1])?
> 
> I'd also like to propose 100 as the limit (120 makes three way diffs
> tricky
> to fit on the screen). David Ezzio suggested 90 in the [DISCUSS] thread so
> that might warrant consideration.
> 
> [1] http://source.android.com/submit-patches/code-style-guide
> -mike
> 
> On Thu, Jun 18, 2009 at 9:06 AM, Pinaki Poddar <ppoddar@apache.org> wrote:
> 
>>
>> Proposal to increase the line width limit to 120 chars from existing 80
>> chars.
>>
>> +1 : change it to 120 (or something greater than 80)
>> -1 : keep it to 80 (or something less than 80)
>> 0  : i do not care
>>
>>
>>
>>
>> Reason: New API classes/methods have long names and often require
>> multiple
>> generic parameters with bounds. 80-char line width is hampering
>> readability
>> than helping it.
>>
>>
>>
>> -----
>> Pinaki
>> --
>> View this message in context:
>> http://n2.nabble.com/-VOTE-%3A-Extend-the-source-test-code-line-width-to-120-chars-tp3113489p3113489.html
>> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>>
>>
> 
> 


-----
Pinaki 
-- 
View this message in context: http://n2.nabble.com/-VOTE-%3A-Extend-the-source-test-code-line-width-to-120-chars-tp3113489p3113869.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.


Mime
View raw message