Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: local policy)
MIME-version: 1.0
Date: Thu, 21 May 2009 17:17:25 -0700
From: Craig L Russell <Craig.Russell@Sun.COM>
Subject: Re: [VOTE] Turn off enhancement by subclassing as the default
In-reply-to: <1242859511151-2949153.post@n2.nabble.com>
Sender: Craig.Russell@Sun.COM
To: dev@openjpa.apache.org
Message-id: <7A4D7D92-AD9E-436E-B115-6542C6736FB4@SUN.com>
Content-type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha1; boundary=Apple-Mail-134-503756576
References: <89c0c52c0812041625x69489674x59d052ffae528e37@mail.gmail.com>
 <1242859511151-2949153.post@n2.nabble.com>

--Apple-Mail-134-503756576
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit

+1 to turn it off in both 1.3 and trunk.

Turning it off will not let it be forgotten. Every user who naively  
runs without benefit of enhancement will get a nice message just like  
today. The difference is that after getting the message that  
enhancement was not done, today the user continues and tomorrow the  
user will have to actually read the message.

The message should direct the user to explicit instructions on how to  
enhance the classes, and how to run without enhancement.

I can tell you that it took me a while to figure it out.

Craig

On May 20, 2009, at 3:45 PM, Pinaki Poddar wrote:

>
> Hi Kevin,
>
>  +1 on 1.3 if you mean "turn off" as
> openjpa.RuntimeUnenhancedClasses=unsupported.
>
> I am rather ambivalent about trunk though.
>
> Few more aspects that we should take note of:
>  1. We must recognize the core notion behind runtime enhancement is a
> strong and useful feature.
>
>  2. The available support has its flaws (which is the reason for this
> discussion being resurrected) -- but more importantly, we do not  
> know the
> footprint of the incompleteness of this feature. Given that we run  
> our test
> corpus on enhanced classes only, we basically wait till a user's  
> report is
> diagnosed as yet another bug caused by this feature.
>
>  3. "Turning it off" has the risk of this powerful feature being
> "forgotten" -- if it turns out so, it will not be a desirable outcome.
>
>
> -----
> Pinaki Poddar                      http://ppoddar.blogspot.com/
>
> http://www.linkedin.com/in/pinakipoddar
> OpenJPA PMC Member/Committer
> JPA Expert Group Member
> -- 
> View this message in context: http://n2.nabble.com/-VOTE--Turn-off-enhancement-by-subclassing-as-the-default-tp1616140p2949153.html
> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>

Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


--Apple-Mail-134-503756576
Content-Disposition: attachment;
	filename=smime.p7s
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw
ggJyoAMCAQICEDXZ+Ig/3d9DjJZ8u++ZnC0wDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx
JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTE4MTYwMloXDTA5MTIwOTE4MTYw
MlowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny
YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC
ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOe3oksetTgSiqqWllhIYBT0dWhR4CitzXDf
+ETyrtEF2HWRRpfwixLpV1Az8wwFzNKfjvQn3tQh0A/VDDeepDEM9TKLP+D6qShLR/KTf5kCMyT4
mILJYIDo/JMmTIH5jceojvlTDFd0gd+XXNAGGz1Wu2XxfvFDE/lpFnQkKYE+VjjENONy4JlkJnOI
rSfMlb+zHPAUmMTtmhxYIDLgov4Jv2Z5pUKZMpNcYr+7jJeUxkxKwWm4im56h7CGP0Yhkq2Je506
mqKCFImxofBjkHZISVS5m7WaGs4lViDtwLQEPtyUt7RcaoYWTvEQtvoy1TE2oZDUaAYFxVu0cHUW
bU0CAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC
MAAwDQYJKoZIhvcNAQEFBQADgYEAQaqAADs5GLyk9iO1xfmNFySpOXXofJPEbfbt77BK/WLhLOwS
69WIxSmGMpGGUlLd6FJ1xfLzsvP9/N5tmZQlpGcBoEwrn830JcbNyEG0ANcmdeAy2yBjNjWoIDhV
QmQw8OgJDk0xi0Tv/UYm9uPxOhDJOA67a3v6FHvSAbLqBScwggM/MIICqKADAgECAgENMA0GCSqG
SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH
EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp
Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h
aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw
NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl
IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls
IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE
cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef
kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB
AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js
LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD
VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB
AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+
hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC
3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0ECEDXZ+Ig/3d9DjJZ8u++ZnC0wCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN
AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDkwNTIyMDAxNzI1WjAjBgkqhkiG9w0B
CQQxFgQUMdEakAlu2QO5dnuPAM+zAea6qwIwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC
WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0
ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA12fiIP93fQ4yWfLvvmZwtMIGHBgsqhkiG
9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ
dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA1
2fiIP93fQ4yWfLvvmZwtMA0GCSqGSIb3DQEBAQUABIIBAIYgNs7nQLOD0zNKmvbKHF5sfc4kNsBc
npMpCkGGuf7iNK8TMyUUQ3iFkmH7xidWXsHDlZXzcbqeYM18KuOfRyDg9T4hClM8WyJpWJtxD7a9
pyO8R5rOWNxOODpBVCPBdB53F4jaz8AaD5xvov0QZEx8K0Tt+tiveTw8b2j/jeh7oD8+NfrO+Y0U
FDVeWLr4CgGOfjaMLeuKYRFkDSPI9D7Hmt+eKRCwY7g+NAUpzhEc8RdW+Br6Du6DlfotwPH7emx6
eWeoBLlMLHpjTvD92RZ1MkV8Sz2FFp7XTnweF2QQjxN6MF2WE6KAxIeMYUFMuIIJxGZsnroX/XQ/
lXsrpXsAAAAAAAA=

--Apple-Mail-134-503756576--