Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Message-ID: <1329790621.1242841425654.JavaMail.jira@brutus>
Date: Wed, 20 May 2009 10:43:45 -0700 (PDT)
From: "Craig Russell (JIRA)" <jira@apache.org>
To: dev@openjpa.apache.org
Subject: [jira] Commented: (OPENJPA-1062) Include OSGi bundle metadata
In-Reply-To: <969378345.1241548110691.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OPENJPA-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711253#action_12711253 ] 

Craig Russell commented on OPENJPA-1062:
----------------------------------------

> By marking <scope>compile</scope>, then those dependencies are only used at compile time and are not included as maven transitive dependencies, which helps maven-bundle-plugin create more accurate bundle metadata.

My understanding is different. I understand that if you have a compile-time dependency, then it's a permanent dependency that carries through test, integration, and runtime. But I'm not a maven expert.

> openjpa-lib - Log4J is optional, as there are LogFactoryAdapter impls for Log4J, Commons-logging and No logging. 

So if you have a requirement that might be needed at runtime (e.g. log4j) and you can compile without it, it should be marked as provided.

> Ant is only needed when calling the enhancer or reverse mapping tool from Ant. 

So ant should be a test dependency or a provided dependency.

> openjpa-jdbc - Postgresql and Hsqldb are only compile time depends for the PostgresqlDictionary and HSQLDictionary classes

This is interesting. These are open source libraries so there's no harm in including them. It just struck me as odd that we would have a hard dependency on these database-specific libraries, but upon reflection, I think you're right to include them as compile dependencies.

> I still want a couple more eyes to look at this (like maybe Mike) and I want to run some more tests before committing.

+1

> Include OSGi bundle metadata
> ----------------------------
>
>                 Key: OPENJPA-1062
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1062
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: build / infrastructure
>    Affects Versions: 1.2.1, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>             Fix For: 2.0.0
>
>         Attachments: OPENJPA-1062-bundle_only.patch, OPENJPA-1062.patch
>
>
> Use the maven-bundle-plugin to generate the OSGi bundle metadata in the manifest.mf.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.