From dev-return-11966-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Tue May 19 12:49:11 2009 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 29365 invoked from network); 19 May 2009 12:49:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 19 May 2009 12:49:10 -0000 Received: (qmail 99005 invoked by uid 500); 19 May 2009 12:49:10 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 98941 invoked by uid 500); 19 May 2009 12:49:10 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 98931 invoked by uid 99); 19 May 2009 12:49:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2009 12:49:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2009 12:49:07 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D90B7234C045 for ; Tue, 19 May 2009 05:48:45 -0700 (PDT) Message-ID: <1000299489.1242737325888.JavaMail.jira@brutus> Date: Tue, 19 May 2009 05:48:45 -0700 (PDT) From: "Milosz Tylenda (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-976) Research the need for escape charaters for LIKE in various DB's In-Reply-To: <519717361.1236865610560.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710722#action_12710722 ] Milosz Tylenda commented on OPENJPA-976: ---------------------------------------- Mike, I think we got a bit off-topic in this issue. I suggest that the outcome of this issue be a list of databases which gives answers to: - does the database require ESCAPE [char] clause in LIKE? - if the databse does not require the ESCAPE clause: does it assume some default escaping char or does not it do any escaping at all? - does the database poses any constraints on the escaping chracters? E.g. a back-slash must be prefixed with another back-slash. If we got the list, we modify the code (possibly in a new JIRA issue) for the case when a JPQL string does not specify ESCAPE char: - we don't generate ESCAPE clause for databases that don't require it - possibly we could think of what to do if a database happens to assume some default escaping char (maybe there is no such database) We might also need to think of the case when a JPQL string specifies ESCAPE char but the database poses a constraint, e.g. the double back-slash (another JIRA issue). This is how I understand the problem raised here and in OPENJPA-975. Maybe it is too much and for the beginning we want to do only a subset of the changes. As for the list of databases, I can say PostgreSQL does not require ESCAPE so it looks like Oracle is not alone in their camp. > Research the need for escape charaters for LIKE in various DB's > --------------------------------------------------------------- > > Key: OPENJPA-976 > URL: https://issues.apache.org/jira/browse/OPENJPA-976 > Project: OpenJPA > Issue Type: Improvement > Components: jdbc > Reporter: B.J. Reed > Assignee: B.J. Reed > Priority: Minor > Attachments: OPENJPA-976.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > A new requiresSearchStringEscapeForLike field was added to the DBDictionary in http://issues.apache.org/jira/browse/OPENJPA-975. Currently, the default is true and the OracleDictionary overwrites it to false. Need to investigate other DB's to see what other dictionaries would be better off as false.. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.