openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-832) Add eclipse formatting preferences to website
Date Tue, 12 May 2009 21:07:45 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708625#action_12708625
] 

Michael Dick commented on OPENJPA-832:
--------------------------------------

Hi Milosz, 

1. Curly braces for one line if/else statements are intentional - if we're following the Sun
Java code conventions. It isn't widely used throughout the code though - I believe the original
code drop used a different set of conventions and we've never cleaned them up. 

FWIW I clean them up when I see them in code I'm changing. 

2. I think I'm the original owner of the formatting preferences (not trying to steal credit
- they just match my settings - could have been someone else). If so the compiler settings
are an oversight, I just exported my config and sent it around after a cursory glance at the
contents.

3. I've only used the GUI to generate the config, so I'm not sure what you mean. The GUI claims
it only wraps when necessary. 

Donald,

You're not alone. The eclipse formatter doesn't seem to work perfectly for me either - seems
to ignore it if just a curly brace goes past 80 chars, and some other miscellaneous problems
(maybe #3). 

> Add eclipse formatting preferences to website
> ---------------------------------------------
>
>                 Key: OPENJPA-832
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-832
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: build / infrastructure
>            Reporter: Michael Dick
>            Assignee: Donald Woods
>            Priority: Minor
>         Attachments: openjpa-formatter.xml
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message