Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: domain of michael.d.dick@gmail.com
 designates 209.85.220.222 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=fbHtcenTlJ4jFLblp95XazlWNPx7cwerMbTe58DKx9/6d8KFdKn8Fjhov2MAa/DJNw
         wJoiw5lvB8JhjzDfjO5THtROsvA8iAawE8pKYBve8r26KmdtfIPyjFHbDtqq0Ji34Y3v
         5BFmcHxpk5XKGHy9mPGcUZ5Z7EBVaz20iuEWA=
MIME-Version: 1.0
Date: Mon, 6 Apr 2009 10:30:14 -0500
Message-ID: <72c1350f0904060830w5f77b33alfe7af79f8a290476@mail.gmail.com>
Subject: [DISCUSS] refactor @AllowFailure
From: Michael Dick <michael.d.dick@gmail.com>
To: dev@openjpa.apache.org
Content-Type: multipart/alternative; boundary=001636c5a7172ff0180466e4930a

--001636c5a7172ff0180466e4930a
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi all,

The AllowFailure annotation is very useful in that it allows specific test
methods to be ignored during a typical Maven build.

The implementation, however is rather confusing as a "clean" build of
OpenJPA will typically contain several stack traces from exceptions. Running
these optional tests that currently do not pass just consumes CPU cycles
that could be better spent elsewhere.

I propose refactoring @AllowFailure to be called @OptionalTest (or just
@Optional) and updating the supporting methods in PersistenceTestCase so
that test methods (or classes) annotated with @OptionalTest are skipped
unless a jvm system property is true (ie -Dopenjpa.optional.tests=true).

I think this will save everyone's CPU cycles without violating the intent of
@AllowFailure. In addition with this change we could resurrect the changes
for OPENJPA-770 and we could clean up the root pom.xml a bit.

Anyone else have strong opinions about @AllowFailure?

-mike

--001636c5a7172ff0180466e4930a--