Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 39764 invoked from network); 3 Apr 2009 06:05:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Apr 2009 06:05:34 -0000 Received: (qmail 3023 invoked by uid 500); 3 Apr 2009 06:05:34 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 2946 invoked by uid 500); 3 Apr 2009 06:05:34 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 2935 invoked by uid 99); 3 Apr 2009 06:05:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2009 06:05:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2009 06:05:33 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id EB21E234C003 for ; Thu, 2 Apr 2009 23:05:12 -0700 (PDT) Message-ID: <2055859968.1238738712944.JavaMail.jira@brutus> Date: Thu, 2 Apr 2009 23:05:12 -0700 (PDT) From: "Albert Lee (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-1015) Enforce 80-column line width for source code In-Reply-To: <1870011503.1238527610652.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695251#action_12695251 ] Albert Lee commented on OPENJPA-1015: ------------------------------------- After applying/updating to the latest commits, I am getting the folllowing error when "mvn clean install -DskipTests=true": [INFO] ------------------------------------------------------------------------ [INFO] Building OpenJPA Utilities [INFO] task-segment: [clean, install] [INFO] ------------------------------------------------------------------------ [INFO] [clean:clean] [INFO] Deleting file set: C:\a.tools.alleetp\wasx.serv1\openjpa.cur\openjpa-lib\target (included: [**], excluded: []) [INFO] [checkstyle:checkstyle {execution: default}] [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] An error has occurred in Checkstyle report generation. Embedded error: Unable to find configuration file at location checkstyle.xml Could not find resource 'checkstyle.xml'. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 6 seconds Where Is this checkstyle.xml file and is it supposedly part of the commit or I have to create it somehow? Thanks, > Enforce 80-column line width for source code > -------------------------------------------- > > Key: OPENJPA-1015 > URL: https://issues.apache.org/jira/browse/OPENJPA-1015 > Project: OpenJPA > Issue Type: Test > Reporter: Pinaki Poddar > Assignee: B.J. Reed > Attachments: line80.txt, OPENJPA-1015-max80chars.patch, OPENJPA-1015-newlineendoffile.patch, TestLineWidth.java > > > There used to be a rule of 80-column width for source code. > That rule is slowly yielding. > Should we add a test case to catch such violation? > Or should we not reignite the age-old battle about line width, placement of brackets etc? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.