openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "B.J. Reed (JIRA)" <j...@apache.org>
Subject [jira] Updated: (OPENJPA-1015) Enforce 80-column line width for source code
Date Thu, 02 Apr 2009 15:10:12 GMT

     [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

B.J. Reed updated OPENJPA-1015:
-------------------------------

    Attachment: OPENJPA-1015-max80chars.patch

Attaching OPENJPA-1015-max80chars.patch.  This is the first of many large patches for fixing
code style issues.  This adds the maven-checkstyle-plugin to the report part of the build
and a temporary checkstyle.xml to the build.  The idea is that as we get closer to the Sun
codestyle recommendations, we can just remove this file and update the pom.xml to use the
defaults.  After using mvn site, you can check the target/site/checkstyle file to see how
many style issues were found.

85% of the line overruns found by this plugin were caused by tabs or by extra white space
at the end of the line or in comments.  Tabs show up as 8 characters on some editors so it
is counted as 8 characters by the checkstyle plugin.  Tabs seem to be absolutely everywhere,
so it would be a good idea for everyone (myself included) to make sure that you are not creating
more tabs in files as you check them in.



> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>            Assignee: B.J. Reed
>         Attachments: line80.txt, OPENJPA-1015-max80chars.patch, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message