openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1015) Enforce 80-column line width for source code
Date Wed, 01 Apr 2009 15:29:13 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694576#action_12694576
] 

Michael Dick commented on OPENJPA-1015:
---------------------------------------

I think it's useless if it doesn't execute as part of the main build and prevent successful
builds if there are errors (this is why we should only enable a subset of rules). 

If it's only in a profile then it'll get ignored and we'll have to do periodic cleanup commits.


Running the default report (all sun conventions checked) on trunk took 55 seconds on my laptop
(including time to download the plugin and its dependencies). Running a subset of the rules
should be quicker (might not be noticeable). 

FWIW my laptop is a Lenovo T60 (1.8x GHz dual core). YMMV. 



> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>            Assignee: B.J. Reed
>         Attachments: line80.txt, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message