openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1015) Enforce 80-column line width for source code
Date Thu, 02 Apr 2009 20:11:13 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695110#action_12695110
] 

Michael Dick commented on OPENJPA-1015:
---------------------------------------

Thanks for the patch B.J. A couple comments though :

1.) Can we put an Apache license at the top of checkstyle.xml? If not we'll have to exclude
it from the rat checking (look for the rat plugin in the release profile), and add the appropriate
documentation in NOTICE.txt (I think). 

2.) Looks like you fixed a few tabs along the way. It isn't a big deal once I checked for
them. 

> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>            Assignee: B.J. Reed
>         Attachments: line80.txt, OPENJPA-1015-max80chars.patch, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message