openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Milosz Tylenda (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-887) Assertion oversight in TestLibService
Date Wed, 01 Apr 2009 15:09:13 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694569#action_12694569
] 

Milosz Tylenda commented on OPENJPA-887:
----------------------------------------

Thanks, Mike. I was aware of this "revert property" feature but was not sure whether I should
use this.

Actually, only trunk commit was without a message, the 1.3.x commit had a message but it does
not matter now.




> Assertion oversight in TestLibService
> -------------------------------------
>
>                 Key: OPENJPA-887
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-887
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Trivial
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back
to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...).  The above compiles because of autoboxing
creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message