openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1015) Enforce 80-column line width for source code
Date Tue, 07 Apr 2009 13:50:12 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696532#action_12696532
] 

Michael Dick commented on OPENJPA-1015:
---------------------------------------

I've created a subtask to enable the newline rule and moved B.J.'s patch there in order to
confine the svn changes associated with this issue to a manageable number (especially when
moved to branches). 

The remaining work to be done for this issue is to apply the changes to testcases as well
and then determine which branches should also include this change.

> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>            Assignee: B.J. Reed
>             Fix For: 2.0.0
>
>         Attachments: line80.txt, OPENJPA-1015-audit-output.patch, OPENJPA-1015-checkstyle.xml.patch,
OPENJPA-1015-max80chars.patch, OPENJPA-1015-newlineendoffile.patch, OPENJPA-1015-plugin-version.patch,
TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message