openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-1015) Enforce 80-column line width for source code
Date Fri, 03 Apr 2009 03:15:13 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695218#action_12695218
] 

Michael Dick commented on OPENJPA-1015:
---------------------------------------

I've committed the 80 character width patch for trunk with a few changes. The main change
is to make the check part of a normal build - not just a report that you can optionally generate.


If you do a normal maven build and you have a file that violates the rule you'll get an error
message like this one : 

[INFO] ------------------------------------------------------------------------
[INFO] Building OpenJPA Utilities
[INFO]    task-segment: [compile]
[INFO] ------------------------------------------------------------------------
[INFO] [checkstyle:checkstyle {execution: default}]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] An error has occurred in Checkstyle report generation.

Embedded error: There are 1 checkstyle errors.
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------

Further experimentation may show a way to print the offending file. As it is today one would
have to run svn diff and manually inspect the files that have been changed. For smaller commits
this is easily done, larger commits may want to run mvn site and examine the full checkstyle
report to see which files exhibit the problem. 




> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>            Assignee: B.J. Reed
>         Attachments: line80.txt, OPENJPA-1015-max80chars.patch, OPENJPA-1015-newlineendoffile.patch,
TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message