Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: domain of michael.d.dick@gmail.com
 designates 209.85.220.161 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=rc2vM7nl7gNXgB6/Ss/xFqRfSV/EbbbMNHzybRe5c+0wmYEbHF87TziwGuhrcJycI/
         YzRbwuUA9JgiE8k7YWXzr6isMmOAy2dsrgxYiPkqqFS8zxzhO5MvtMR+FkhxxAEONqA0
         3opQfQOZbHRvQ67Pfzo2uOpM+VZnwLfoZ25lk=
MIME-Version: 1.0
In-Reply-To: <8e68c8e90903060745x114f1bb7gd83f79e83474275a@mail.gmail.com>
References: <72c1350f0903050821y2d5635eo3756e9fbc82425f1@mail.gmail.com>
	 <67d4b338.34c496f5.49b10745.a8be7@o2.pl>
	 <72c1350f0903060706w70a3fb56ud58f5d13e54bde58@mail.gmail.com>
	 <8e68c8e90903060745x114f1bb7gd83f79e83474275a@mail.gmail.com>
Date: Fri, 6 Mar 2009 10:14:04 -0600
Message-ID: <72c1350f0903060814j25758ec4n486afe2fe224eb78@mail.gmail.com>
Subject: Re: [VOTE] Approve OpenJPA 1.2.1 release
From: Michael Dick <michael.d.dick@gmail.com>
To: dev@openjpa.apache.org
Content-Type: multipart/alternative; boundary=001636c5b352d5cd7b046475924d

--001636c5b352d5cd7b046475924d
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable

Hi Albert comments inline.

2009/3/6 Albert Lee <allee8285@gmail.com>

> Mike, just a few comments
>
> 1) In the release note, the " Release Notes - OpenJPA - Version 1.2.1."
> should be hightlighted.


We can do this in future releases. I'm not sure it's worth re-spinning just
for a formatting change.


> 2) The link below can remove the suffix "&view=3Dmarkup" so that it goes
> right
> to display the content.


+1, the revision was just a copy from the link in viewcvs. A better link is
here :

http://svn.apache.org/viewvc/openjpa/tags/1.2.1/openjpa-project/RELEASE-NOT=
ES.html?view=3Dmarkup
<http://svn.apache.org/viewvc/openjpa/tags/1.2.1/openjpa-project/RELEASE-NO=
TES.html?revision=3D749830&view=3Dmarkup>


> 3) The binary.zip is 18 Mb, which is 7 Mb less than the version of the
> previous release. Looks like the javadoc and source java files are remove=
d
> from the openjpa.121.jar in the binary zip file.


That's intentional see OPENJPA-713. We could include the sources jar and
javadoc as separate artifacts in *binary.zip if the community  thinks it's
useful. Maybe it's worth creating a javadoc zip as a separate download?

4) The doc links to the TOC of the manul, I wonder if we can link to the
> framed version like
> http://openjpa.apache.org/builds/latest/docs/manual/main.html?


There is no main.html for 1.2.1 at the moment (or it didn't get built I'll
look into it).

Thanks for doing the release.
> Albert Lee.
>
> 2009/3/6 Michael Dick <michael.d.dick@gmail.com>
>
> > Hi Milosz,
> >
> > I messed up and didn't put the right revision number in my link. Try th=
is
> > one :
> >
> >
> >
> http://svn.apache.org/viewvc/openjpa/tags/1.2.1/openjpa-project/RELEASE-N=
OTES.html?revision=3D749830&view=3Dmarkup
> >
> > Thanks for catching it.
> >
> > -mike
> >
> > On Fri, Mar 6, 2009 at 5:21 AM, Mi=B3osz Tylenda <mtylenda@o2.pl> wrote=
:
> >
> > > Mike,
> > >
> > > Are the release notes, you gave a link to, the final version? Its
> > contents
> > > are from 1.1.0 release. On the other hand, the release notes in the
> > binary
> > > distribution seem to be up to date.
> > >
> > > Greetings,
> > > Milosz
> > >
> > >
> > >
> >
>
>
>
> --
> Albert Lee.
>

--001636c5b352d5cd7b046475924d--