Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 60392 invoked from network); 11 Mar 2009 14:05:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Mar 2009 14:05:18 -0000 Received: (qmail 31750 invoked by uid 500); 11 Mar 2009 14:05:18 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 31729 invoked by uid 500); 11 Mar 2009 14:05:18 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 31718 invoked by uid 99); 11 Mar 2009 14:05:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2009 07:05:18 -0700 X-ASF-Spam-Status: No, hits=-1999.8 required=10.0 tests=ALL_TRUSTED,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2009 14:05:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C2B98234C045 for ; Wed, 11 Mar 2009 07:04:50 -0700 (PDT) Message-ID: <1830706479.1236780290796.JavaMail.jira@brutus> Date: Wed, 11 Mar 2009 07:04:50 -0700 (PDT) From: "Albert Lee (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-866) DBDictionary.maxTableNameLength is not checked when using SynchronizeMappings In-Reply-To: <460824889.1232722499495.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680872#action_12680872 ] Albert Lee commented on OPENJPA-866: ------------------------------------ I tried apply the patch against the trunk but mvn clean install consistently failied in: Results : Tests in error: testCacheMarshallerEndToEnd(org.apache.openjpa.conf.TestCacheMarshallerEndToEnd) Tests run: 1374, Failures: 0, Errors: 1, Skipped: 0 I ran the with and without the patch twice and still failed the same say. Can you take a look and see what may be causing the problem ? Thanks, Albert Lee. > DBDictionary.maxTableNameLength is not checked when using SynchronizeMappings > ----------------------------------------------------------------------------- > > Key: OPENJPA-866 > URL: https://issues.apache.org/jira/browse/OPENJPA-866 > Project: OpenJPA > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: Alan Raison > Assignee: Tim McConnell > Attachments: OPENJPA-866_3.patch > > > Per Alan Raison's post to the dev mailing list there appears to be a problem with trimming table names when SynchronizeMappings is used. > Here's the email that started the conversation : > I have been writing a DBDictionary for the Ingres database and have been running the test cases. Ingres supports 32 character table names, and this has been set in the dictionary. However some tests have hit an error whereby the table name is too long for the database. > I notice in the DBDictionary class there is a method called "getValidTableName" but this clearly isn't being used since it is trying to use a table name which is too long. Other databases (such as Oracle) also have quite a short maximum length for table names, so this problem must be able to overcome, but I can't see anything in other Dictionary classes. > Is there anything special I should be doing to run the tests? I am currently running through mvn test. > My draft DBDictionary class is attached along with a sample surefire report (with my username and password removed!) > The full thread can be seen here : http://n2.nabble.com/OpenJPA-1.2.0-Test-Cases---Table-Name-too-Long-td2197132.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.