From dev-return-10963-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Wed Mar 11 18:54:38 2009 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 35398 invoked from network); 11 Mar 2009 18:54:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Mar 2009 18:54:37 -0000 Received: (qmail 94032 invoked by uid 500); 11 Mar 2009 18:54:37 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 94004 invoked by uid 500); 11 Mar 2009 18:54:37 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 93993 invoked by uid 99); 11 Mar 2009 18:54:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2009 11:54:37 -0700 X-ASF-Spam-Status: No, hits=-3.8 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [192.18.43.132] (HELO sca-es-mail-1.sun.com) (192.18.43.132) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2009 18:54:26 +0000 Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n2BIs580011432 for ; Wed, 11 Mar 2009 11:54:05 -0700 (PDT) MIME-version: 1.0 Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7.0-5.01 64bit (built Feb 19 2009)) id <0KGC00100TZ2LP00@fe-sfbay-10.sun.com> for dev@openjpa.apache.org; Wed, 11 Mar 2009 11:54:05 -0700 (PDT) Received: from dhcp-usca14-133-31.SFBay.Sun.COM ([unknown] [129.145.133.31]) by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7.0-5.01 64bit (built Feb 19 2009)) with ESMTPSA id <0KGC00KXHV5T5D50@fe-sfbay-10.sun.com> for dev@openjpa.apache.org; Wed, 11 Mar 2009 11:53:54 -0700 (PDT) Date: Wed, 11 Mar 2009 11:53:53 -0700 From: Craig L Russell Subject: Re: svn commit: r751910 - in /openjpa/trunk: openjpa-kernel/src/main/java/org/apache/openjpa/conf/ openjpa-kernel/src/main/java/org/apache/openjpa/kernel/ openjpa-kernel/src/main/java/org/apache/openjpa/meta/ openjpa-persistence-jdbc/src/test/java/org/apac... In-reply-to: <1236793563782-2462775.post@n2.nabble.com> Sender: Craig.Russell@Sun.COM To: dev@openjpa.apache.org Message-id: <2FB53E75-60F1-4020-A3B4-179A98E4433C@SUN.com> X-Mailer: Apple Mail (2.930.3) Content-type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary=Apple-Mail-41-792395576 References: <0215F188-6D84-426B-B3BF-050FB13181B6@SUN.com> <1236722720578-2458226.post@n2.nabble.com> <1236793563782-2462775.post@n2.nabble.com> X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-41-792395576 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Hi Pinaki, On Mar 11, 2009, at 10:46 AM, Pinaki Poddar wrote: > > Hi Craig, > We are in difficult position if JPA Spec *does not* change the method > signature to return the detached instance (be it a copy or the > original). I > had mailed to Kevin (and now you:) to place such a request with JPA > Spec > committee so that OpenJPA can remain backward compatible. I can see an advantage in *not* being backward compatible. If backward compatible, the application silently fails if the user doesn't read the release notes and doesn't change the configuration. So it might actually be an advantage to throw an exception (signature mismatch) if the user just tries to run with the new incompatible signature OpenJPA implementation. Craig > > > We have not yet changed the API signature of detach() for OpenJPA > as JPA > 2.0 detach() is not yet on the published draft version but soon will > be > (within this week, I suppose). Because detach() still returns an > instance, I > had overlooked the question you raised. > > A test case for new behavior is in > org.apache.openjpa.persistence.detachment.TestDetach. > > Old behavior with the new configuration is indirectly tested by the > whole > test corpus. But few tests in the corpus that failed with the new > behavior > and I had to change their configuration to emulate old behavior are > org.apache.openjpa.persistence.detachment.TestNoCascadeOneToOneMerge > org.apache.openjpa.persistence.simple.TestFlushBeforeDetach.java > > No code change but only configuration change to > "openjpa.Compatibility", > "FlushBeforeDetach=true,CopyOnDetach=true" > > Regards -- > > Pinaki > > > > > Craig L Russell wrote: >> >> Hi Pinaki, >> >> Since the JPA signature has no return value, how can the user get the >> detached objects? >> >> Do you have a test case for the old behavior with the new >> configuration? >> >> Regards, >> >> Craig >> >> On Mar 10, 2009, at 3:05 PM, Pinaki Poddar wrote: >> >>> >>> Hi Craig, >>> I understand your concerns because I had similar ones. That is why >>> this >>> change does retain the past behavior exactly as it was. The user >>> only >>> requires the following configuration to get exactly the same >>> behavior >>> openjpa.Compatibility=FlushBeforeDetach=true,CopyOnDetach=true >>> >>> In fact, JDO having a separate signature as detachCopy() is a good >>> news >>> because then we can add the same signature to Broker so that the >>> user will >>> not even need the above configuration for backward compatible >>> behavior. >>> >>> Regards -- >>> >>> >>> -- >>> View this message in context: >>> http://n2.nabble.com/Re%3A-svn-commit%3A-r751910---in--openjpa-trunk%3A-openjpa-kernel-src-main-java-org-apache-openjpa-conf--openjpa-kernel-src-main-java-org-apache-openjpa-kernel--openjpa-kernel-src-main-java-org-apache-tp2458104p2458226.html >>> Sent from the OpenJPA Developers mailing list archive at Nabble.com. >>> >> >> Craig L Russell >> Architect, Sun Java Enterprise System http://db.apache.org/jdo >> 408 276-5638 mailto:Craig.Russell@sun.com >> P.S. A good JDO? O, Gasp! >> >> >> >> > > -- > View this message in context: http://n2.nabble.com/Re%3A-svn-commit%3A-r751910---in--openjpa-trunk%3A-openjpa-kernel-src-main-java-org-apache-openjpa-conf--openjpa-kernel-src-main-java-org-apache-openjpa-kernel--openjpa-kernel-src-main-java-org-apache-tp2458104p2462775.html > Sent from the OpenJPA Developers mailing list archive at Nabble.com. > Craig L Russell Architect, Sun Java Enterprise System http://db.apache.org/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-41-792395576 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw ggJyoAMCAQICEDXZ+Ig/3d9DjJZ8u++ZnC0wDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTE4MTYwMloXDTA5MTIwOTE4MTYw MlowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOe3oksetTgSiqqWllhIYBT0dWhR4CitzXDf +ETyrtEF2HWRRpfwixLpV1Az8wwFzNKfjvQn3tQh0A/VDDeepDEM9TKLP+D6qShLR/KTf5kCMyT4 mILJYIDo/JMmTIH5jceojvlTDFd0gd+XXNAGGz1Wu2XxfvFDE/lpFnQkKYE+VjjENONy4JlkJnOI rSfMlb+zHPAUmMTtmhxYIDLgov4Jv2Z5pUKZMpNcYr+7jJeUxkxKwWm4im56h7CGP0Yhkq2Je506 mqKCFImxofBjkHZISVS5m7WaGs4lViDtwLQEPtyUt7RcaoYWTvEQtvoy1TE2oZDUaAYFxVu0cHUW bU0CAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC MAAwDQYJKoZIhvcNAQEFBQADgYEAQaqAADs5GLyk9iO1xfmNFySpOXXofJPEbfbt77BK/WLhLOwS 69WIxSmGMpGGUlLd6FJ1xfLzsvP9/N5tmZQlpGcBoEwrn830JcbNyEG0ANcmdeAy2yBjNjWoIDhV QmQw8OgJDk0xi0Tv/UYm9uPxOhDJOA67a3v6FHvSAbLqBScwggM/MIICqKADAgECAgENMA0GCSqG SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+ hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC 3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0ECEDXZ+Ig/3d9DjJZ8u++ZnC0wCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDkwMzExMTg1MzUzWjAjBgkqhkiG9w0B CQQxFgQU9eiwWtRNZxoLVHlqahfR+ALMfccwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0 ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA12fiIP93fQ4yWfLvvmZwtMIGHBgsqhkiG 9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA1 2fiIP93fQ4yWfLvvmZwtMA0GCSqGSIb3DQEBAQUABIIBAG8tvszPnhsAF4uqRn4N7C4LfIoCVtEy TqizxgNsuboIU5vnMCmcewxbbX+CsvqjnP5agCQGHnl4D0Otl9S1Xln1sKL23QIAATSLDNc9LwPe l6c8XMebTb6SdeVje3jljNAs67Kp6RZq2J7DScjvEIo71efcdMxLlGDYuEjoMVpFfcCdEwf9si9+ RpGxEgPONnhiiCNGbO0sHAu3uWUzchE2AAMk7BDRnMac6QDxiGyJur0Ftqdgv6hF83MquqzI8ixc aCjcwsvWOcV+Bb/l0DgZpNvL+LPW8yH+dRNU30ajVP5+nfg65xzyZphEhFf8clVeFkL2h2UXzm/G BzL5b6gAAAAAAAA= --Apple-Mail-41-792395576--